newlib-nano: Fix include path for CT_NEWLIB_NANO_INSTALL_IN_TARGET #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `CT_NEWLIB_NANO_INSTALL_IN_TARGET=y`, the `nano.specs` file emitted by the newlib-nano build script contains an invalid include path, resulting in the full `newlib.h` being included instead of the nano `newlib.h` by the application. `=/include/newlib-nano` is not a valid path (`=` does not mean anything and that string is taken as an include path as-is) and GCC ignores this include path, resulting in application including the `newlib.h` from `include/` which contains the newlib build configurations for the full newlib. This commit modifies the newlib-nano build script to emit a proper newlib-nano include path relative to the `GCC_EXEC_PREFIX`. Signed-off-by: Stephanos Ioannidis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CT_NEWLIB_NANO_INSTALL_IN_TARGET=y, thenano.specsfileemitted by the newlib-nano build script contains an invalid include
path, resulting in the full
newlib.hbeing included instead of thenano
newlib.hby the application.=/include/newlib-nanois not a valid path (=does not mean anythingand that string is taken as an include path as-is) and GCC ignores this
include path, resulting in application including the
newlib.hfrominclude/which contains the newlib build configurations for the fullnewlib.
This commit modifies the newlib-nano build script to emit a proper
newlib-nano include path relative to the
GCC_EXEC_PREFIX.Signed-off-by: Stephanos Ioannidis [email protected]
Upstream PR: crosstool-ng#1721