-
Notifications
You must be signed in to change notification settings - Fork 7.6k
printk: Add tests for print format #44193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
printk: Add tests for print format #44193
Conversation
This is a PR that's building on @MaureenHelm 's find at #41735 (review). It's still a work in progress, but basically I'm finding that in the Kinetis K6X a value such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes to zephyr_stdint.h
should be a separate commit (you can cherry-pick the existing commit 2f6c982).
By the way, during local testing, I saw a bunch of timeouts from twister even though the actual QEMU output was correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toolchain: Add missing U?INT(32|64)_C implementations
These implementations were missing/incorrect for several architectures
that need the zephyr_stdint.h.
Signed-off-by: Yuval Peress <[email protected]>
As noted in #44199 and 2f6c982, these macros were not missing -- they are always internally defined by the toolchain/compiler.
The problem is that Zephyr defines its own stdint types and, unless we re-define/override these integer constant macros as well, they are not going to correspond.
Please update the commit message accordingly.
This commit overrides the toolchain internal `__INTN_C(value)` integer constant macros to match the types defined by the `zephyr_stdint.h` header. For more details, refer to the GitHub issue zephyrproject-rtos#44199. Signed-off-by: Stephanos Ioannidis <[email protected]>
Sorry, finally figured out how to cherry pick from the other repo without adding another remote to my git :) I'm still seeing the timeouts so I'll figure that out and remove the WIP label then |
@yperess By the way, what was causing the timeout earlier? |
A copy paste error in the expected console output. I didn't change the numbers to octal base for PRIo* |
Add tests to verify that the different print formats and constant macros match. Fixes zephyrproject-rtos#44199 Signed-off-by: Yuval Peress <[email protected]>
Add tests to verify that the various
PRI\w\d+
macros map to thecorrect
U?INT\d+_C
macros.Signed-off-by: Yuval Peress [email protected]
Fixes #44199