-
Notifications
You must be signed in to change notification settings - Fork 7.6k
modules: hal_ethos_u: fix failure to override ETHOSU_TARGET_NPU_CONFIG #89977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules: hal_ethos_u: fix failure to override ETHOSU_TARGET_NPU_CONFIG #89977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update the PR with the test that failed or how you encountered the failure?
This failure was found in the port of nuvoton's m55m1 ethos-u (#88941). On m55m1, its ethos-u is ethos-u55-256, not default ethos-u55-128: zephyr/modules/hal_ethos_u/Kconfig Lines 16 to 17 in 70759f1
Build on numaker_m55m1 board:
hal_ethos_u will dump config message, like:
On m55m1 target, |
@ccli8 Thanks! Considering that the Ethos-U Core Driver is added later in that CMake file, I think the FORCE option can be removed? Theoretically it's possible to set the CMake define on CLI, but if the entry has FORCE then that will override everything. |
This fixes failure to override ETHOSU_TARGET_NPU_CONFIG in hal_ethos_u due to CMP0126 not being NEW. See: https://cmake.org/cmake/help/latest/policy/CMP0126.html#policy:CMP0126 Signed-off-by: Chun-Chieh Li <[email protected]>
0177220
to
84f0f7e
Compare
Agree. Removed the |
|
LGTM, but I don't have review rights. Could you approve this from your end please @kristofer-jonsson-arm |
This fixes failure to override
ETHOSU_TARGET_NPU_CONFIG
inhal_ethos_u
due to cmake policy CMP0126 not being NEW.ETHOSU_TARGET_NPU_CONFIG
originally as directory variable will fail to override that inhal_ethos_u
as cache variable.. This is fixed by passing also as cache variable.See:
https://cmake.org/cmake/help/latest/policy/CMP0126.html#policy:CMP0126