Fixes #26, #28 - Updating dependencies #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth saying the fix from #29 should stop these kind of Greenkeeper issues from appearing. |
simmo
commented
Jan 2, 2019
| @@ -2097,7 +2097,6 @@ Object { | |||
| "vue/attribute-hyphenation": "error", | |||
| "vue/attributes-order": "warn", | |||
| "vue/comment-directive": "error", | |||
| "vue/component-name-in-template-casing": "warn", | |||
There was a problem hiding this comment.
Updating vue's recommended config to 5.1 removes this rule.
More info on it here... https://vuejs.github.io/eslint-plugin-vue/rules/component-name-in-template-casing.html
It is still available but has been removed from 'recommended' to 'uncategorised'.
There was a problem hiding this comment.
fyi reasons for change: vuejs/eslint-plugin-vue#703
arashkiani
approved these changes
Jan 2, 2019
sburrows-zone
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR cover?
Bugfix
Breaking change?
Minor
Are all the tests are passing?
Yes
Other information:
This has a minor change for the vue config, that removes a rule.