PSD: add support for 'cmyk', 'multichannel', and 'grayscale' color modes #1641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1603
With this patch to the PSD (Photoshop) reader, I believe we now correctly read grayscale, CMYK, and "multichannel" color modes (in addition to RGB, indexed, and bitmap, as we did before). We still don't support Lab, or duotone color modes (does anybody care?).
Note that we don't correctly read 32 bit images in any of these modes (even the ones we THOUGHT we did correctly before -- they were wrong). I'll tackle that as a separate PR, or perhaps amend this one if I really find the problem immediately, we'll see. It seems to be a byte swapping issue.