Fix wrong oiio:UnassociatedAlpha metadata for PSD files #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring in AcademySoftwareFoundation#1641 incorrectly caused this to be set on the last layer rather than the composite image as before. Now set it on the composite image and every layer, as all of them use unassociated alpha.
lgritz
approved these changes
Jan 9, 2023
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 12, 2023
…oundation#3750) Refactoring in AcademySoftwareFoundation#1641 incorrectly caused this to be set on the last layer rather than the composite image as before. Now set it on the composite image and every layer, as all of them use unassociated alpha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring in #1641 incorrectly caused this to be set on the last layer rather than the composite image as before. Now set it on the composite image and every layer, as all of them use unassociated alpha.
Tests
Test was added.
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).