Make sure all build_foo.bash scripts exit upon any error. #2520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set -ex` exists the whole script if any individual command fails. I think this will help ensure that people know when these dependency building scripts have errors, instead of (hypothesized) seeming to execute fully but actually the installation of that dependency was not complete.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 24, 2020
…twareFoundation#2520) `set -ex` exists the whole script if any individual command fails. I think this will help ensure that people know when these dependency building scripts have errors, instead of (hypothesized) seeming to execute fully but actually the installation of that dependency was not complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set -exexists the whole script if any individual command fails. Ithink this will help ensure that people know when these dependency
building scripts have errors, instead of (hypothesized) seeming to
execute fully but actually the installation of that dependency was not
complete.