Skip to content

Make sure all build_foo.bash scripts exit upon any error. #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/build-scripts/build_cmake.bash
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/bash

# Utility script to download and build cmake

# Exit the whole sscript if any command fails.
set -ex

echo "Building cmake"
uname

Expand Down
5 changes: 5 additions & 0 deletions src/build-scripts/build_libraw.bash
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/bash

# Utility script to download and build LibRaw

# Exit the whole sscript if any command fails.
set -ex

# Which LibRaw to retrieve, how to build it
LIBRAW_REPO=${LIBRAW_REPO:=https://github.com/LibRaw/LibRaw.git}
LIBRAW_VERSION=${LIBRAW_VERSION:=0.19.5}
Expand Down
5 changes: 5 additions & 0 deletions src/build-scripts/build_llvm.bash
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/bash

# Utility script to download and build LLVM & clang

# Exit the whole sscript if any command fails.
set -ex

echo "Building LLVM"
uname

Expand Down
5 changes: 5 additions & 0 deletions src/build-scripts/build_ocio.bash
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/bash

# Utility script to download and build OpenColorIO

# Exit the whole sscript if any command fails.
set -ex

OCIO_REPO=${OCIO_REPO:=https://github.com/AcademySoftwareFoundation/OpenColorIO.git}
LOCAL_DEPS_DIR=${LOCAL_DEPS_DIR:=${PWD}/ext}
OCIO_BUILD_DIR=${OCIO_BUILD_DIR:=${LOCAL_DEPS_DIR}/OpenColorIO}
Expand Down
5 changes: 5 additions & 0 deletions src/build-scripts/build_openexr.bash
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/bash

# Utility script to download and build OpenEXR & IlmBase

# Exit the whole sscript if any command fails.
set -ex

# Which OpenEXR to retrieve, how to build it
OPENEXR_REPO=${OPENEXR_REPO:=https://github.com/openexr/openexr.git}
OPENEXR_VERSION=${OPENEXR_VERSION:=2.4.0}
Expand Down
5 changes: 3 additions & 2 deletions src/build-scripts/build_pybind11.bash
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#!/bin/bash

# Utility script to download and build pybind11 if it doesn't exist on the
# system.
# Utility script to download and build pybind11

# Exit the whole sscript if any command fails.
set -ex

# Repo and branch/tag/commit of pybind11 to download if we don't have it yet
PYBIND11_REPO=${PYBIND11_REPO:=https://github.com/pybind/pybind11.git}
Expand Down