Skip to content

Close the help center when clicking the Big Sky add site card #103937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

dereksmart
Copy link
Member

@dereksmart dereksmart commented Jun 3, 2025

Fixes DOTCOM-13474

Proposed Changes

When clicking the Big Sky add new site card, make sure to close the help center if it's open.

Why are these changes being made?

To make sure the help center doesn't stay open through the site creation and onboarding.

Testing Instructions

  • http://calypso.localhost:3000/sites
  • Open the help center
  • Click Add New Site -> AI website builder
  • Help center should close. And remain closed throughout
  • Test on a slow network too.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dereksmart dereksmart requested a review from a team as a code owner June 3, 2025 19:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 3, 2025
@dereksmart dereksmart requested a review from a team June 3, 2025 19:33
Copy link

github-actions bot commented Jun 3, 2025

@matticbot
Copy link
Contributor

matticbot commented Jun 3, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/close-help-center-add-big-sky-card on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~56 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-dashboard-sites-add-new-site       +150 B  (+2.1%)      +56 B  (+2.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@@ -77,7 +74,12 @@ function AddNewSite( { context }: AddNewSiteProps ) {
description={ __(
'Prompt, edit, and launch WordPress websites with Artificial Intelligence.'
) }
onClick={ bigSkyClick }
onClick={ () => {
setShowHelpCenter( false ); // Close the help center
Copy link
Contributor

@paulopmt1 paulopmt1 Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's working as expected, and after understanding the code, I can ensure this is indeed a proper solution.

Once we close the help center, we send a PUT request to our backend

image

That's used on both Calypso + /wp-admin to know whether to show it or not:

image

Thanks for the quick fix!

@dereksmart dereksmart merged commit 88c28f1 into trunk Jun 3, 2025
13 checks passed
@dereksmart dereksmart deleted the fix/close-help-center-add-big-sky-card branch June 3, 2025 19:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 3, 2025
@arthur791004
Copy link
Contributor

It doesn't work on dashboard v2. I'll propose a fix soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants