-
Notifications
You must be signed in to change notification settings - Fork 2k
Close the help center when clicking the Big Sky add site card #103937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~56 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
@@ -77,7 +74,12 @@ function AddNewSite( { context }: AddNewSiteProps ) { | |||
description={ __( | |||
'Prompt, edit, and launch WordPress websites with Artificial Intelligence.' | |||
) } | |||
onClick={ bigSkyClick } | |||
onClick={ () => { | |||
setShowHelpCenter( false ); // Close the help center |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It's working as expected, and after understanding the code, I can ensure this is indeed a proper solution.
Once we close the help center, we send a PUT request to our backend
That's used on both Calypso + /wp-admin to know whether to show it or not:
Thanks for the quick fix!
It doesn't work on dashboard v2. I'll propose a fix soon 🙂 |
Fixes DOTCOM-13474
Proposed Changes
When clicking the Big Sky add new site card, make sure to close the help center if it's open.
Why are these changes being made?
To make sure the help center doesn't stay open through the site creation and onboarding.
Testing Instructions
Pre-merge Checklist