Skip to content

Dashboard v2: Fix Add new site because the help center store is not ready #104064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jun 9, 2025

Part of #103937

Proposed Changes

  • Fixes the issue introduced in #103937 where "Add New Site" on Dashboard v2 fails due to the Help Center store not being initialized..

Why are these changes being made?

  • The "Add new site" button is broken

Testing Instructions

  • Go to /v2
  • Click "Add new site" button
  • Ensure you can see the modal

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jun 9, 2025

@arthur791004 arthur791004 self-assigned this Jun 9, 2025
@arthur791004 arthur791004 marked this pull request as ready for review June 9, 2025 06:18
@arthur791004 arthur791004 requested a review from a team as a code owner June 9, 2025 06:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 9, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/dashboard-v2-create-site on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~61 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site             +102 B  (+0.0%)      +61 B  (+0.0%)
sites-dashboard          +102 B  (+0.0%)      +61 B  (+0.0%)
site-settings            +102 B  (+0.0%)      +61 B  (+0.0%)
site-performance         +102 B  (+0.0%)      +61 B  (+0.0%)
site-monitoring          +102 B  (+0.0%)      +61 B  (+0.0%)
site-logs                +102 B  (+0.0%)      +61 B  (+0.0%)
plans                    +102 B  (+0.0%)      +61 B  (+0.0%)
overview                 +102 B  (+0.0%)      +61 B  (+0.0%)
hosting                  +102 B  (+0.0%)      +61 B  (+0.0%)
github-deployments       +102 B  (+0.0%)      +61 B  (+0.0%)
domains                  +102 B  (+0.0%)      +61 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3209 bytes added 📈 [gzipped])

name                                             parsed_size             gzip_size
async-load-calypso-dashboard-sites-add-new-site      +8467 B  (+116.7%)    +3209 B  (+119.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the issue is fixed 👍

@arthur791004 arthur791004 merged commit 4fda569 into trunk Jun 9, 2025
13 of 14 checks passed
@arthur791004 arthur791004 deleted the fix/dashboard-v2-create-site branch June 9, 2025 09:27
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants