Skip to content

FontIconSource markup extension #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Feb 12, 2020

This PR is part of the group being tracked in #3108.

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

A XAML markup extension that creates a FontIconSource from a string representing a Segoe MDL2 icon, resulting in much cleaner code (see here). All additional info can be found in the linked issue.

This issue is related to #3110.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Feb 12, 2020

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned azchohfi Feb 12, 2020
@Sergio0694 Sergio0694 mentioned this pull request Feb 12, 2020
7 tasks
Copy link
Contributor

@vgromfeld vgromfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michael-hawker
Copy link
Member

michael-hawker commented Mar 24, 2020

@Sergio0694 I feel like this should this just be added to the #3110 PR instead? (And we should have tests for both.)

@michael-hawker
Copy link
Member

@Sergio0694 can we just merge this into the PR for #3110 since it provide very similar functionality? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants