Skip to content

BitmapIconSource extension #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sergio0694
Copy link
Member

Follow up for #3110 and #3129

PR Type

What kind of change does this PR introduce?

  • Feature
  • Refactoring (no functional changes, no api changes)

What is the current behavior?

There was no extension for BitmapIconSource.
Also the SymbolIcon were using the wrong name for the Glyph property.

What is the new behavior?

  • Added a new BitmapIconSource extension
  • Changed the Glyph property to Symbol when using the Symbol type. This follows the naming of the actual original SymbolIcon class from UWP.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Jun 6, 2020

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michael-hawker
Copy link
Member

This was an oversight on a missing API for completeness found during our doc review here, which we should have gotten to a bit sooner outside of our other circumstances.

I think this is a good improvement to make now vs. later, and we've got a bit more stabilization time now too.

Will commit PR as we have @chingucoding's review as well, thanks for jumping in! 🦙❤

@michael-hawker michael-hawker merged commit 6dc0314 into CommunityToolkit:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants