Xaml Islands Fixes for FocusManager.GetFocusedElement and ContentDial… #3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
70 tasks
|
@azchohfi can you link to the blog post here or in the issue with the list of all the changes XAML Islands needs? Will be good for future reference to have it linked to here if folks stumble upon this in the future. |
UnitTests/UnitTests.XamlIslands.UWPApp/XamlIslandsTest_TokenizingTextBox.cs
Outdated
Show resolved
Hide resolved
michael-hawker
approved these changes
Jun 23, 2020
This was referenced Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3340 #3216 #3205
Fixed issues with any class using FocusManager.GetFocusedElement when running inside the context of a Xaml Island, as well as one last issue with TextToolbar's ContentDialog not having it's XamlRoot set, also in the context of a Xaml Island.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
FocusManager.GetFocusedElement() always returns null when executed in the context of a Xaml Island, so any class that leverages this method will not work properly on Xaml Islands, as reported in #3340.
What is the new behavior?
If XamlRoot is available, calls the new overload FocusManager.GetFocusedElement(XamlRoot), with the appropriate XamlRoot.
PR Checklist
Please check if your PR fulfills the following requirements: