-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Feature/animation apis revamp #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/animation apis revamp #3639
Conversation
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@Sergio0694 I noticed the Offset sample isn't triggering on Loaded for some reason unlike the other ones??? It seems to be the only one that's not playing it's animation on Load? Also looks like you accidently overwrote the Fade sample with the Blur sample? Pointed out the commit inline below. |
</media:PipelineVisualFactory> | ||
</media:UIElementExtensions.VisualFactory> | ||
<ani:Explicit.Animations> | ||
<ani:AnimationSet x:Name="BlurAnimation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not sure what happened here, but this used to be the Fade example? Looks like a mistake in e5ee018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, sorry! 😅
Fixed in 6196cdf, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with Changes, @RosarioPulella assume you and Sergio will be up before I will, so once the Fade and Offset samples are fixed we should be good to merge this unless you find any other issues. Then feel free to merge the dev/new-animations
branch to master and update the dev/split-controls
so you can continue on. 🎉
…/EffectAnimations.bind
@Sergio0694 you added the |
Seems like it was caused by the layout pass updating the offset after that and stopping the animation. |
Added in 4f35471 😄 |
## Follow up for #3639 <!-- Add a brief overview here of the feature/bug & fix. --> ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more that apply to this PR. --> - Feature - Improvements <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Changelog This PR tracks new changes and tweaks for the `Microsoft.Toolkit.Uwp.UI.Animations` package before the 7.0 release. Changes are done according to feedbacks and requests from developers trying out the Preview 5 release. This PR contains the following changes: - All `AnimationBuilder` and XAML animation types now use `AnimationDelayBehavior.SetValueBeforeDelay` by default - New `DelayBehavior` property available for XAML animation types (ignored when an animation is on the XAML layer) - New `delayBehavior` parameter available for the explicit `AnimationBuilder` keyframe animation APIs (the more advanced ones) - New `RepeatOption` parameter now available for all `AnimationBuilder` APIs (default, keyframe, etc.) Opening as a draft PR until we finalize the list of changes to add. ## PR Checklist Please check if your PR fulfills the following requirements: - [X] Tested code with current [supported SDKs](../readme.md#supported) - [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link --> - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets) - [X] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc... - [ ] Tests for the changes have been added (for bug fixes / features) (if applicable) - [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [ ] Contains **NO** breaking changes
Closes #3638
PR Type
What kind of change does this PR introduce?
Overview
This PR introduces an oberhaul of the animation package, by adding new APIs, doing a refactoring of the existing animation APIs, and also introducing extension points for both the behaviors and media packages. For more info, see linked issue.
APIs breakdown
AnimationBuilder (click to expand):
Keyframe animation builders (click to expand):
Extensions (click to expand):
XAML animation types (click to expand):
Attached properties (click to expand):
Animation behaviors (click to expand):
Effect animations (click to expand):
Pipeline effects factory (click to expand):
PR Checklist
Please check if your PR fulfills the following requirements: