Animations package improvements #3796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
michael-hawker,
azchohfi,
Kyaa-dost and
Rosuavio
Sergio0694
force-pushed
the
improvements/animations-package
branch
2 times, most recently
from
0c04580 to
5f091ce
Compare
Rosuavio
approved these changes
Mar 2, 2021
8 tasks
Sergio0694
force-pushed
the
improvements/animations-package
branch
2 times, most recently
from
1de3d38 to
ffa8992
Compare
Sergio0694
force-pushed
the
improvements/animations-package
branch
from
ffa8992 to
b6f2835
Compare
michael-hawker
approved these changes
Mar 3, 2021
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sergio0694
force-pushed
the
improvements/animations-package
branch
from
53eb3d2 to
e27c0d7
Compare
9 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #3639
PR Type
What kind of change does this PR introduce?
Changelog
This PR tracks new changes and tweaks for the
Microsoft.Toolkit.Uwp.UI.Animationspackage before the 7.0 release.Changes are done according to feedbacks and requests from developers trying out the Preview 5 release.
This PR contains the following changes:
AnimationBuilderand XAML animation types now useAnimationDelayBehavior.SetValueBeforeDelayby defaultDelayBehaviorproperty available for XAML animation types (ignored when an animation is on the XAML layer)delayBehaviorparameter available for the explicitAnimationBuilderkeyframe animation APIs (the more advanced ones)RepeatOptionparameter now available for allAnimationBuilderAPIs (default, keyframe, etc.)Opening as a draft PR until we finalize the list of changes to add.
PR Checklist
Please check if your PR fulfills the following requirements: