Add back array models for compatibility #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was too much of a breaking change to remove all array models, let's keep them around as no-op for the time being.
skarimo
approved these changes
Jun 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Add back array models for compatibility It was too much of a breaking change to remove all array models, let's keep them around as no-op for the time being. * Fix naming * Remove incorrect model * Handle errors a bit nicer 1c813ad
skarimo
added a commit
that referenced
this pull request
Jun 5, 2023
* Revert "Add back array models for compatibility (#1499)" This reverts commit 1c813ad. * re-add old models * generate * cleanup * add back list models to apis * fix naming * fix typing * fix more models and typing info * remove models that didnt exist in 2.12.0 * docs * cleanup generator * update examples * fix * fix Simple model unparsed * undo models added after 2.12.0
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Revert "Add back array models for compatibility (#1499)" This reverts commit 1c813ad. * re-add old models * generate * cleanup * add back list models to apis * fix naming * fix typing * fix more models and typing info * remove models that didnt exist in 2.12.0 * docs * cleanup generator * update examples * fix * fix Simple model unparsed * undo models added after 2.12.0 49a0dd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep import compatibility let's introduce no-op models with warnings.
Closes #1496, #1497.