-
Notifications
You must be signed in to change notification settings - Fork 48
Re-introduce array container models #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c813ad.
therve
reviewed
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing the NotifyEnd* models?
I omitted these purposefully along with |
nkzou
approved these changes
Jun 5, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Revert "Add back array models for compatibility (#1499)" This reverts commit 1c813ad. * re-add old models * generate * cleanup * add back list models to apis * fix naming * fix typing * fix more models and typing info * remove models that didnt exist in 2.12.0 * docs * cleanup generator * update examples * fix * fix Simple model unparsed * undo models added after 2.12.0 49a0dd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the original changes in PR: #1431 and removes the models added in: #1499
closes: #1501