Skip to content

Re-introduce array container models #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 5, 2023
Merged

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Jun 2, 2023

This reverts the original changes in PR: #1431 and removes the models added in: #1499

closes: #1501

@skarimo skarimo requested a review from a team as a code owner June 2, 2023 20:39
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing the NotifyEnd* models?

@skarimo
Copy link
Member Author

skarimo commented Jun 5, 2023

I think we're missing the NotifyEnd* models?

I omitted these purposefully along with FindingTags and ListFindingsData, since these models were introduced post 2.12.0 release.

@skarimo skarimo merged commit 49a0dd9 into master Jun 5, 2023
@skarimo skarimo deleted the sherz/revert-list-models-change branch June 5, 2023 14:38
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
* Revert "Add back array models for compatibility (#1499)"

This reverts commit 1c813ad.

* re-add old models

* generate

* cleanup

* add back list models to apis

* fix naming

* fix typing

* fix more models and typing info

* remove models that didnt exist in 2.12.0

* docs

* cleanup generator

* update examples

* fix

* fix Simple model unparsed

* undo models added after 2.12.0 49a0dd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change to metrics_query_metadata.py
3 participants