-
Notifications
You must be signed in to change notification settings - Fork 305
Use the latest docker build image to fix the Oracle Java 8 issue (was using JRE instead of JDK) #8932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.gitlab-ci.yml
Outdated
@@ -27,7 +27,7 @@ variables: | |||
GRADLE_VERSION: "8.5" # must match gradle-wrapper.properties | |||
MAVEN_REPOSITORY_PROXY: "http://artifactual.artifactual.all-clusters.local-dc.fabric.dog:8081/repository/maven-central/" | |||
GRADLE_PLUGIN_PROXY: "http://artifactual.artifactual.all-clusters.local-dc.fabric.dog:8081/repository/gradle-plugin-portal-proxy/" | |||
JAVA_BUILD_IMAGE_VERSION: "v25.05" | |||
JAVA_BUILD_IMAGE_VERSION: "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this change is not working. All jobs failed.
Also we have a reference to this variable in update-docker-build-image.yaml
file.
Probably we should update to v25.06
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it.
I tweaked a bit the gitlab file to use a prefix var rather than the version directly.
The reason is that latest
docker images are not tagged latest-base
, latest-7
, ... but base
, 7
, ...
Given this is temporary for the next 2-3 weeks (v25.06 is scheduled end of this month), this might be acceptable.
f11260d
to
c7c1ea5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 18 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~cd4b6b436c, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1029703
Total [baseline] (8.585 s) : 0, 8584999
Agent [candidate] (1.032 s) : 0, 1031586
Total [candidate] (8.565 s) : 0, 8564788
section iast
Agent [baseline] (1.149 s) : 0, 1149178
Total [baseline] (9.212 s) : 0, 9212039
Agent [candidate] (1.15 s) : 0, 1150070
Total [candidate] (9.176 s) : 0, 9175886
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.152 s) : 0, 1151926
Total [baseline] (9.139 s) : 0, 9138756
Agent [candidate] (1.158 s) : 0, 1158132
Total [candidate] (9.141 s) : 0, 9141406
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1146362
Total [baseline] (9.191 s) : 0, 9190753
Agent [candidate] (1.143 s) : 0, 1142890
Total [candidate] (9.217 s) : 0, 9217216
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~cd4b6b436c, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.684 ms) : 0, 686684
BytebuddyAgent [candidate] (688.094 ms) : 0, 688094
GlobalTracer [baseline] (241.214 ms) : 0, 241214
GlobalTracer [candidate] (241.91 ms) : 0, 241910
AppSec [baseline] (57.458 ms) : 0, 57458
AppSec [candidate] (56.402 ms) : 0, 56402
Debugger [baseline] (6.202 ms) : 0, 6202
Debugger [candidate] (6.947 ms) : 0, 6947
Remote Config [baseline] (737.716 µs) : 0, 738
Remote Config [candidate] (757.184 µs) : 0, 757
Telemetry [baseline] (13.741 ms) : 0, 13741
Telemetry [candidate] (13.674 ms) : 0, 13674
section iast
BytebuddyAgent [baseline] (802.249 ms) : 0, 802249
BytebuddyAgent [candidate] (802.647 ms) : 0, 802647
GlobalTracer [baseline] (230.08 ms) : 0, 230080
GlobalTracer [candidate] (230.786 ms) : 0, 230786
IAST [baseline] (27.454 ms) : 0, 27454
IAST [candidate] (27.428 ms) : 0, 27428
AppSec [baseline] (51.32 ms) : 0, 51320
AppSec [candidate] (51.129 ms) : 0, 51129
Debugger [baseline] (5.974 ms) : 0, 5974
Debugger [candidate] (5.978 ms) : 0, 5978
Remote Config [baseline] (599.402 µs) : 0, 599
Remote Config [candidate] (609.94 µs) : 0, 610
Telemetry [baseline] (7.953 ms) : 0, 7953
Telemetry [candidate] (7.919 ms) : 0, 7919
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.111 ms) : 0, 803111
BytebuddyAgent [candidate] (807.2 ms) : 0, 807200
GlobalTracer [baseline] (230.52 ms) : 0, 230520
GlobalTracer [candidate] (232.179 ms) : 0, 232179
IAST [baseline] (26.399 ms) : 0, 26399
IAST [candidate] (28.093 ms) : 0, 28093
AppSec [baseline] (53.723 ms) : 0, 53723
AppSec [candidate] (52.387 ms) : 0, 52387
Debugger [baseline] (5.986 ms) : 0, 5986
Debugger [candidate] (6.05 ms) : 0, 6050
Remote Config [baseline] (613.468 µs) : 0, 613
Remote Config [candidate] (627.527 µs) : 0, 628
Telemetry [baseline] (7.946 ms) : 0, 7946
Telemetry [candidate] (7.987 ms) : 0, 7987
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.467 ms) : 0, 798467
BytebuddyAgent [candidate] (796.106 ms) : 0, 796106
GlobalTracer [baseline] (230.555 ms) : 0, 230555
GlobalTracer [candidate] (230.095 ms) : 0, 230095
IAST [baseline] (28.062 ms) : 0, 28062
IAST [candidate] (28.597 ms) : 0, 28597
AppSec [baseline] (51.288 ms) : 0, 51288
AppSec [candidate] (49.989 ms) : 0, 49989
Debugger [baseline] (6.038 ms) : 0, 6038
Debugger [candidate] (5.976 ms) : 0, 5976
Remote Config [baseline] (625.005 µs) : 0, 625
Remote Config [candidate] (598.081 µs) : 0, 598
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (8.103 ms) : 0, 8103
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~cd4b6b436c, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030096
Total [baseline] (11.194 s) : 0, 11193580
Agent [candidate] (1.029 s) : 0, 1029360
Total [candidate] (11.15 s) : 0, 11149916
section appsec
Agent [baseline] (1.163 s) : 0, 1162853
Total [baseline] (11.203 s) : 0, 11202866
Agent [candidate] (1.165 s) : 0, 1165361
Total [candidate] (11.217 s) : 0, 11216667
section iast
Agent [baseline] (1.15 s) : 0, 1150255
Total [baseline] (11.373 s) : 0, 11373165
Agent [candidate] (1.151 s) : 0, 1150593
Total [candidate] (11.34 s) : 0, 11339939
section profiling
Agent [baseline] (1.263 s) : 0, 1263058
Total [baseline] (11.538 s) : 0, 11538456
Agent [candidate] (1.266 s) : 0, 1266433
Total [candidate] (11.531 s) : 0, 11531043
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~cd4b6b436c, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.024 ms) : 0, 689024
BytebuddyAgent [candidate] (686.868 ms) : 0, 686868
GlobalTracer [baseline] (242.141 ms) : 0, 242141
GlobalTracer [candidate] (242.354 ms) : 0, 242354
AppSec [baseline] (58.213 ms) : 0, 58213
AppSec [candidate] (57.926 ms) : 0, 57926
Debugger [baseline] (6.247 ms) : 0, 6247
Debugger [candidate] (6.229 ms) : 0, 6229
Remote Config [baseline] (753.538 µs) : 0, 754
Remote Config [candidate] (740.614 µs) : 0, 741
Telemetry [baseline] (9.889 ms) : 0, 9889
Telemetry [candidate] (11.466 ms) : 0, 11466
section appsec
BytebuddyAgent [baseline] (700.53 ms) : 0, 700530
BytebuddyAgent [candidate] (702.011 ms) : 0, 702011
GlobalTracer [baseline] (237.566 ms) : 0, 237566
GlobalTracer [candidate] (238.246 ms) : 0, 238246
IAST [baseline] (21.885 ms) : 0, 21885
IAST [candidate] (21.711 ms) : 0, 21711
AppSec [baseline] (175.816 ms) : 0, 175816
AppSec [candidate] (176.754 ms) : 0, 176754
Debugger [baseline] (6.348 ms) : 0, 6348
Debugger [candidate] (5.942 ms) : 0, 5942
Remote Config [baseline] (639.297 µs) : 0, 639
Remote Config [candidate] (638.601 µs) : 0, 639
Telemetry [baseline] (7.321 ms) : 0, 7321
Telemetry [candidate] (7.349 ms) : 0, 7349
section iast
BytebuddyAgent [baseline] (801.362 ms) : 0, 801362
BytebuddyAgent [candidate] (802.07 ms) : 0, 802070
GlobalTracer [baseline] (230.491 ms) : 0, 230491
GlobalTracer [candidate] (230.841 ms) : 0, 230841
IAST [baseline] (25.454 ms) : 0, 25454
IAST [candidate] (27.576 ms) : 0, 27576
AppSec [baseline] (54.631 ms) : 0, 54631
AppSec [candidate] (51.908 ms) : 0, 51908
Debugger [baseline] (6.095 ms) : 0, 6095
Debugger [candidate] (5.997 ms) : 0, 5997
Remote Config [baseline] (631.404 µs) : 0, 631
Remote Config [candidate] (596.942 µs) : 0, 597
Telemetry [baseline] (7.955 ms) : 0, 7955
Telemetry [candidate] (8.014 ms) : 0, 8014
section profiling
BytebuddyAgent [baseline] (674.075 ms) : 0, 674075
BytebuddyAgent [candidate] (674.707 ms) : 0, 674707
GlobalTracer [baseline] (359.273 ms) : 0, 359273
GlobalTracer [candidate] (361.16 ms) : 0, 361160
AppSec [baseline] (61.768 ms) : 0, 61768
AppSec [candidate] (61.824 ms) : 0, 61824
Debugger [baseline] (6.1 ms) : 0, 6100
Debugger [candidate] (6.136 ms) : 0, 6136
Remote Config [baseline] (658.686 µs) : 0, 659
Remote Config [candidate] (646.806 µs) : 0, 647
Telemetry [baseline] (8.086 ms) : 0, 8086
Telemetry [candidate] (8.132 ms) : 0, 8132
ProfilingAgent [baseline] (102.38 ms) : 0, 102380
ProfilingAgent [candidate] (102.995 ms) : 0, 102995
Profiling [baseline] (102.403 ms) : 0, 102403
Profiling [candidate] (103.019 ms) : 0, 103019
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 5 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~cd4b6b436c, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (8.252 ms) : 8229, 8275
. : milestone, 8252,
appsec (6.333 ms) : 6092, 6573
. : milestone, 6333,
appsec_no_iast (4.49 ms) : 4274, 4706
. : milestone, 4490,
code_origins (1.507 ms) : 1354, 1660
. : milestone, 1507,
iast (3.023 ms) : 2829, 3217
. : milestone, 3023,
profiling (11.26 ms) : 11172, 11348
. : milestone, 11260,
tracing (8.482 ms) : 8454, 8511
. : milestone, 8482,
section candidate
no_agent (13.903 ms) : 13766, 14040
. : milestone, 13903,
appsec (74.665 ms) : 73623, 75706
. : milestone, 74665,
appsec_no_iast (84.107 ms) : 82930, 85284
. : milestone, 84107,
code_origins (99.62 ms) : 97430, 101810
. : milestone, 99620,
iast (91.638 ms) : 90149, 93127
. : milestone, 91638,
profiling (65.437 ms) : 64500, 66374
. : milestone, 65437,
tracing (55.129 ms) : 54286, 55973
. : milestone, 55129,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~cd4b6b436c, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (15.6 s) : 15600000, 15600000
. : milestone, 15600000,
appsec (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
iast (18.974 s) : 18974000, 18974000
. : milestone, 18974000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
. : milestone, 17839000,
profiling (15.167 s) : 15167000, 15167000
. : milestone, 15167000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
section candidate
no_agent (15.487 s) : 15487000, 15487000
. : milestone, 15487000,
appsec (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
iast (18.648 s) : 18648000, 18648000
. : milestone, 18648000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
. : milestone, 17834000,
profiling (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
tracing (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~cd4b6b436c, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.392 ms) : 2343, 2441
. : milestone, 2392,
iast (2.183 ms) : 2122, 2245
. : milestone, 2183,
iast_GLOBAL (2.224 ms) : 2162, 2286
. : milestone, 2224,
profiling (2.054 ms) : 2003, 2104
. : milestone, 2054,
tracing (2.004 ms) : 1956, 2052
. : milestone, 2004,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.398 ms) : 2349, 2447
. : milestone, 2398,
iast (2.18 ms) : 2118, 2241
. : milestone, 2180,
iast_GLOBAL (2.226 ms) : 2165, 2288
. : milestone, 2226,
profiling (2.496 ms) : 2318, 2675
. : milestone, 2496,
tracing (1.997 ms) : 1949, 2045
. : milestone, 1997,
|
c7c1ea5
to
d0f360f
Compare
Rebased on #8943 |
1bcd915
to
cd4b6b4
Compare
FYI was green on the previous commit c7c1ea5 https://github.com/DataDog/dd-trace-java/actions/runs/15487436667 |
What Does This Do
https://github.com/DataDog/dd-trace-java-docker-build/pkgs/container/dd-trace-java-docker-build/431585654?tag=latest
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]