Skip to content

v2.9.7 #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 7, 2021
Merged

v2.9.7 #1294

merged 15 commits into from
Aug 7, 2021

Conversation

jc21
Copy link
Member

@jc21 jc21 commented Aug 7, 2021

No description provided.

gabbe and others added 15 commits June 30, 2021 14:11
If a custom location is currently set to proxy to a DNS hostname this hostname is cached by nginx. When the underlying IP for the hostname changes this will be cached in nginx until it is restarted. This behaviour is somewhat undesirable if utilising containers.

This change sets the proxy_pass for custom locations into a variable and utilises said variable for routing to the upstream backend. This will ensure that nginx will utilise the resolver and resolve the hostname to the current IP instead of relying on the nginx cache.
Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.13...v4.4.15)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…r-4.4.15

Bump tar from 4.4.13 to 4.4.15 in /backend
Bumps [tar](https://github.com/npm/node-tar) from 6.0.2 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.0.2...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Utilise variable for custom locations proxy_pass
….1.6

Bump tar from 6.0.2 to 6.1.6 in /docs
Since we have newer certbot available, it's time to support more modern and safer ECDSA keys instead of RSA.
@jc21
Copy link
Member Author

jc21 commented Aug 7, 2021

This is an automated message from CI:

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1294

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21
Copy link
Member Author

jc21 commented Aug 7, 2021

This is an automated message from CI:

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1294

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21 jc21 merged commit c47f6fd into master Aug 7, 2021
@parmigiano-tech
Copy link

Hello Everyone!
First of all, i love the work you guys have done here! Thats a great tool for managing ingress meshs on docker swarm environments.

In the latest release (2.9.7) i suspect that a new bug has been introduced by commit 6c1ae77.

I found that using multiple locations nginx gets "confused" on the scope of the $upstream variable and sends requests to the wrong endpoint, causing redirection errors or worse on complex configurations.

For now reverting to 2.9.6 solved the issue, but i found it important to make the mantainers aware of the issue

@jc21
Copy link
Member Author

jc21 commented Aug 22, 2021

Thanks @natanparmigianoreis

Are you able to provide some replication steps and example of the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants