Added tests for edge cases #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgd
reviewed
May 23, 2025
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| public class VanillaCpuLayoutPropertiesParseTest { |
There was a problem hiding this comment.
We should cover Ryzen and Epyc here
There was a problem hiding this comment.
The CPU model here is illustrative, we could change the names of the test.
There was a problem hiding this comment.
Got it, the properties files are cpuinfo dumps IIRC - it would prove that the parser handles the latest layouts (I assume it should just work)
tgd
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds 10 new JUnit tests (+3 CPU-layout fixtures) to harden the Java Thread Affinity project against edge cases.
It touches only the
src/testtree – no production code is modified.AffinityLockDumpLocksTestdumpLocks()lists all threads currently holding locks.AffinityLockReleaseTestAffinityLock.release()restores the mask toBASE_AFFINITY.AffinityResetToBaseAffinityTestAffinity.resetToBaseAffinity()resets the calling thread correctly.AffinityThreadFactoryTestAffinityThreadFactoryeach bind to a distinct CPU (Linux only).CpuInfoLayoutMappingTest/proc/cpuinfointo a correct logical-to-physical map.UtilitiesTestUtilities.toHexStringandtoBinaryStringwith high/empty bits.VanillaCpuLayoutPropertiesParseTest.propertieslayouts (i3, dual-Xeon, dual-E5405) and validates counts.(Three helper classes extend
BaseAffinityTestto reuse temporary-dir handling and Linux checks.)Improves confidence in affinity-lock lifecycle, CPU-layout parsing, and utility helpers.