Skip to content

1900 Add support to save patch data into NIfTI or PNG files #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 3, 2021
Merged

1900 Add support to save patch data into NIfTI or PNG files #1922

merged 8 commits into from
Apr 3, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Apr 2, 2021

Fixes #1900 .

Description

This PR added support to save patch data into nifti or png files.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 2, 2021

/black

@Nic-Ma Nic-Ma requested review from wyli, rijobro and ericspod April 2, 2021 13:25
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 2, 2021

/black

wyli
wyli reviewed Apr 2, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to make patch_index part of the meta_data? I feel image array + meta make more sense than array + meta + patch_index

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 3, 2021

is it possible to make patch_index part of the meta_data? I feel image array + meta make more sense than array + meta + patch_index

In the sample crop, the output data is a list of dict, so I think we should add the index to the dict directly.

Thanks.

@Nic-Ma Nic-Ma merged commit 03b7560 into Project-MONAI:master Apr 3, 2021
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@Nic-Ma @wyli @nsrivathsa
1900 Add support to save patch data into NIfTI or PNG files (Project-…
26749ff 
…MONAI#1922)

* [DLMED] SaveImage supports patch data

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
@Nic-Ma Nic-Ma deleted the 1900-save-batch branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SaveImageD transform need to support list of dict data
2 participants
@Nic-Ma @wyli