Skip to content

1987 Add support for a list of Tensor in metrics handlers #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 10, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Apr 10, 2021

Fixes #1987 .

Description

This PR added support to compute metrics on a list of Tensor data.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from rijobro and wyli April 10, 2021 17:03
@wyli
Copy link
Contributor

wyli commented Apr 10, 2021

/integration-test

wyli and others added 6 commits April 10, 2021 18:48
@wyli wyli enabled auto-merge (squash) April 10, 2021 22:24
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 1987-metrics-support-list branch from 1ba0221 to 88560a1 Compare April 10, 2021 22:59
@wyli wyli disabled auto-merge April 10, 2021 23:41
@wyli wyli enabled auto-merge (squash) April 10, 2021 23:41
@wyli wyli merged commit 5eed058 into Project-MONAI:master Apr 10, 2021
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
…NAI#1988)

* [DLMED] metrics support a list of tensor

Signed-off-by: Nic Ma <[email protected]>

* update workflow test

Signed-off-by: Wenqi Li <[email protected]>

* [DLMED] fix engine.state.output dict copy issue

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add num_workers

Signed-off-by: Nic Ma <[email protected]>

* fixes typos

Signed-off-by: Wenqi Li <[email protected]>

* update tests

Signed-off-by: Wenqi Li <[email protected]>

* update docstrings

Signed-off-by: Wenqi Li <[email protected]>

* tests

Signed-off-by: Wenqi Li <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
@Nic-Ma Nic-Ma deleted the 1987-metrics-support-list branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to compute metrics on list of channel-first data
2 participants