Skip to content

2648 Add LongestRescale transform #2662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 29, 2021
Merged

2648 Add LongestRescale transform #2662

merged 18 commits into from
Jul 29, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 27, 2021 •
edited
Loading

part of #2648 .

Description

This PR added the LongestRescale and LongestRescaled transforms, inspired by the albumentations API.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 11 commits February 1, 2021 19:15
@Nic-Ma
Merge pull request #19 from Project-MONAI/master
42a45e0 
merge master
@Nic-Ma
Merge pull request #32 from Project-MONAI/master
cd16a13 
merge master
@Nic-Ma
Merge pull request #180 from Project-MONAI/dev
6f87afd 
merge master
@Nic-Ma
Merge pull request #185 from Project-MONAI/dev
b06a9b7 
merge master
@Nic-Ma
[DLMED] init the transform
aff3502 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] update doc-string
b987d4e 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Merge branch 'dev' into 2648-longest-resize
6af382f
@Nic-Ma
[DLMED] complete array transform
d35ea5d 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] add unit tests
0c97bc8 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] add dict transform and inverse tests
853a2d1 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] fix mypy type
2b3ba8b 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 28, 2021

/black

@Nic-Ma Nic-Ma changed the title [WIP] 2648 Add LongestRescale transform 2648 Add LongestRescale transform Jul 28, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 28, 2021 13:00
Nic-Ma
Nic-Ma commented Jul 28, 2021
View reviewed changes
@Nic-Ma Nic-Ma requested review from rijobro, wyli and ericspod July 28, 2021 13:02
@wyli
Copy link
Contributor

wyli commented Jul 28, 2021

I think there's a large overlap between this and Resize, Resize also supports int as the spatial_size. would be nice to merge this into Resize, and provide a flexible size_mode for Resize. maybe in the future with different size_mode, we'll have different interpretation for cases such as spatial_size=32 and spatial_size=(32, -1, -1)

wyli
wyli approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick updates

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 28, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 28, 2021 15:42
@madil90
Copy link
Contributor

madil90 commented Jul 28, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Jul 28, 2021

/build

1 similar comment
@madil90
Copy link
Contributor

madil90 commented Jul 28, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 28, 2021

Hi @madil90 ,

May I know why the blossom CI failed? I tried to re-run it, but it still fails.

Thanks in advance.

@Nic-Ma Nic-Ma merged commit d8613b2 into Project-MONAI:dev Jul 29, 2021
wyli pushed a commit to wyli/MONAI that referenced this pull request Aug 3, 2021
@Nic-Ma @wyli
2648 Add LongestRescale transform (Project-MONAI#2662)
c82b5cf 
* [DLMED] init the transform

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update doc-string

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] complete array transform

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add unit tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add dict transform and inverse tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix mypy type

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] change to enhance Resize transform

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix CI tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix TTA

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] remove tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix mypy error

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nic-Ma @wyli @madil90