Skip to content

Scale intensity #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Scale intensity #2832

merged 5 commits into from
Aug 25, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Aug 24, 2021

Description

ScaleIntensity as numpy/torch transform. Requires #2829.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma and wyli and removed request for Nic-Ma August 24, 2021 16:04
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@wyli
Copy link
Contributor

wyli commented Aug 24, 2021

/build

@wyli wyli enabled auto-merge (squash) August 24, 2021 18:59
@wyli
Copy link
Contributor

wyli commented Aug 24, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Aug 25, 2021

/build

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the quick update!
We may need to address the # type: ignore type annotation later.

@wyli wyli merged commit fa5bc15 into Project-MONAI:dev Aug 25, 2021
@rijobro rijobro deleted the scale_intensity branch August 25, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants