Skip to content

all close #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2021
Merged

all close #2829

merged 2 commits into from
Aug 24, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Aug 24, 2021

Description

allclose function for testing

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from wyli and Nic-Ma August 24, 2021 14:22
@rijobro rijobro enabled auto-merge (squash) August 24, 2021 14:30
Signed-off-by: Richard Brown <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli
Copy link
Contributor

wyli commented Aug 24, 2021

/build

@rijobro rijobro mentioned this pull request Aug 24, 2021
4 tasks
@rijobro
Copy link
Contributor Author

rijobro commented Aug 24, 2021

Clicking on the blossom-ci error, it takes me to the results for the Torch flip PR. @wyli any ideas? I'm guessing the results aren't private?

@rijobro rijobro mentioned this pull request Aug 24, 2021
4 tasks
@wyli
Copy link
Contributor

wyli commented Aug 24, 2021

Clicking on the blossom-ci error, it takes me to the results for the Torch flip PR. @wyli any ideas? I'm guessing the results aren't private?

I see, thanks for reporting this, the log is automatically associated with a wrong commit hash, looks like it's the current head of dev @madil90. But I think the log itself is correct (error due to dataset downloading issue):

2021-08-24T15:49:02.4621498Z Traceback (most recent call last):
2021-08-24T15:49:02.4622456Z   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/tests/test_lr_finder.py", line 63, in test_lr_finder
2021-08-24T15:49:02.4623181Z     train_ds = MedNISTDataset(
2021-08-24T15:49:02.4624105Z   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/datasets.py", line 88, in __init__
2021-08-24T15:49:02.4625067Z     download_and_extract(self.resource, tarfile_name, root_dir, self.md5)
2021-08-24T15:49:02.4626160Z   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/utils.py", line 272, in download_and_extract
2021-08-24T15:49:02.4627114Z     download_url(url=url, filepath=filename, hash_val=hash_val, hash_type=hash_type, progress=progress)
2021-08-24T15:49:02.4628242Z   File "/home/jenkins/agent/workspace/MONAI-premerge/monai/monai/apps/utils.py", line 164, in download_url
2021-08-24T15:49:02.4629112Z     gdown.download(url, tmp_name, quiet=not progress)
2021-08-24T15:49:02.4629970Z   File "/usr/local/lib/python3.8/dist-packages/gdown/download.py", line 114, in download
2021-08-24T15:49:02.4630641Z     res = sess.get(url, headers=headers, stream=True)
2021-08-24T15:49:02.4631529Z   File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 555, in get
2021-08-24T15:49:02.4632325Z     return self.request('GET', url, **kwargs)
2021-08-24T15:49:02.4633145Z   File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 542, in request
2021-08-24T15:49:02.4633787Z     resp = self.send(prep, **send_kwargs)
2021-08-24T15:49:02.4634751Z   File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 677, in send
2021-08-24T15:49:02.4635383Z     history = [resp for resp in gen]
2021-08-24T15:49:02.4636238Z   File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 677, in <listcomp>
2021-08-24T15:49:02.4637744Z     history = [resp for resp in gen]
2021-08-24T15:49:02.4638687Z   File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 237, in resolve_redirects
2021-08-24T15:49:02.4639367Z     resp = self.send(
2021-08-24T15:49:02.4640197Z   File "/usr/local/lib/python3.8/dist-packages/requests/sessions.py", line 655, in send
2021-08-24T15:49:02.4640888Z     r = adapter.send(request, **kwargs)
2021-08-24T15:49:02.4641775Z   File "/usr/local/lib/python3.8/dist-packages/requests/adapters.py", line 514, in send
2021-08-24T15:49:02.4642469Z     raise SSLError(e, request=request)
2021-08-24T15:49:02.4645492Z requests.exceptions.SSLError: HTTPSConnectionPool(host='doc-04-ao-docs.googleusercontent.com', port=443): Max retries exceeded with url: /docs/securesc/9p9r8gsv21p6f08r3o04if3gqrtqv1s2/l22nt5odgarfjm30ljfpp48lbutjkn7c/1629819225000/00176608654401740282/00986226090714311076Z/1QsnnkvZyJPcbRoV_ArW8SnE1OTuoVbKE?e=download (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1131)')))

@wyli
Copy link
Contributor

wyli commented Aug 24, 2021

/build

@rijobro rijobro merged commit b4def1a into Project-MONAI:dev Aug 24, 2021
@rijobro rijobro deleted the allclose branch August 25, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants