Skip to content

2873 Simplify random seed logic #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Aug 31, 2021

Fixes #2873 .

Description

This PR simplified the random seed logic according to feedback.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 31, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 31, 2021

Hi @yiheng-wang-nv ,

Is this PR the modification you suggested?

Thanks in advance.

@Nic-Ma Nic-Ma enabled auto-merge (squash) August 31, 2021 22:54
@Nic-Ma Nic-Ma merged commit 9990179 into Project-MONAI:dev Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_determinism can be enhanced
2 participants