-
Notifications
You must be signed in to change notification settings - Fork 1.2k
6676 port generative networks transformer #7300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6676 port generative networks transformer #7300
Conversation
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Overall looks good to me.
Could you please help add more test?
Similarly like this, multiple loops cover the most of the situation. This makes it easier to find bugs later on when refactoring. At the moment, it appears that there is only one hardcoded case.
MONAI/tests/test_selfattention.py
Lines 28 to 35 in d5585c3
for dropout_rate in np.linspace(0, 1, 4): | |
for hidden_size in [360, 480, 600, 768]: | |
for num_heads in [4, 6, 8, 12]: | |
test_case = [ | |
{"hidden_size": hidden_size, "num_heads": num_heads, "dropout_rate": dropout_rate}, | |
(2, 512, hidden_size), | |
(2, 512, hidden_size), | |
] |
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
/build |
Taking a look today |
Towards Project-MONAI#6676 . ### Description Adds a simple decoder-only transformer architecture. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Mark Graham <[email protected]>
Towards #6676 .
Description
Adds a simple decoder-only transformer architecture.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.