Skip to content

feat(YouTube): Add an option to disable toasts when changing default playback speed or quality #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2025
Merged

feat(YouTube): Add an option to disable toasts when changing default playback speed or quality #5230

merged 4 commits into from
Jun 23, 2025

Conversation

MarcaDian
Copy link
Contributor

Closes #5199

@MarcaDian
Copy link
Contributor Author

MarcaDian commented Jun 22, 2025 •
edited
Loading

During testing, I found a small bug unrelated to this PR

Screenshot_2025-06-22-16-32-56-292_app.revancede.android.youtube.jpg

Screenshot_2025-06-22-16-33-26-003_app.revancede.android.youtube-edit.jpg

LisoUseInAIKyrios
LisoUseInAIKyrios reviewed Jun 22, 2025
View reviewed changes
LisoUseInAIKyrios
LisoUseInAIKyrios reviewed Jun 22, 2025
View reviewed changes
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Jun 22, 2025 •
edited
Loading

Maybe try using double instead of float here. It's rounding off wrong because of the low precision of adding 0.05f instead of adding 0.05 (double).

revanced-patches/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/playback/speed/CustomPlaybackSpeedPatch.java

Line 619 in 1ef0c75

private static float roundSpeedToNearestIncrement(float speed) {

@MarcaDian

This comment was marked as resolved.

Sign in to view
@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Jun 22, 2025 that may be closed by this pull request
feat(YouTube): Add an option to disable toasts when changing default playback speed or quality #5199
Closed
3 tasks
@MarcaDian MarcaDian force-pushed the do-not-show-speed-quality-toasts branch from 1fc7d7f to 621c98a Compare June 22, 2025 15:55
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit c68cde3 into ReVanced:dev Jun 23, 2025
1 check passed
@MarcaDian MarcaDian deleted the do-not-show-speed-quality-toasts branch June 23, 2025 08:21
github-actions bot pushed a commit that referenced this pull request Jun 23, 2025
@semantic-release-bot
chore: Release v5.29.0-dev.1 [skip ci]
25ff2ad 
# [5.29.0-dev.1](v5.28.1-dev.2...v5.29.0-dev.1) (2025-06-23)

### Bug Fixes

* **YouTube:** Always use single threaded layout to resolve layout bugs in unpatched YouTube ([#5226](#5226)) ([1f539b1](1f539b1))

### Features

* **YouTube:** Add an option to disable toasts when changing default playback speed or quality ([#5230](#5230)) ([c68cde3](c68cde3))
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
@semantic-release-bot
chore: Release v5.29.0 [skip ci]
37d16d7 
# [5.29.0](v5.28.0...v5.29.0) (2025-06-26)

### Bug Fixes

* Add scrollable content to modern style settings dialogs ([#5211](#5211)) ([e6876d5](e6876d5))
* **Google Photos:** Resolve startup crash for Android 5.0 devices ([0294533](0294533))
* **YouTube - Hide ads:** Hide new type of product ad in video description ([#5225](#5225)) ([1e2efad](1e2efad))
* **YouTube - Hide layout components:** Fix "Hide video description attributes" ([#5250](#5250)) ([2f22d45](2f22d45))
* **YouTube - Hide Shorts components:** Fix "Hide Use this sound button" ([#5233](#5233)) ([5d6ec9e](5d6ec9e))
* **YouTube - Hide Shorts components:** Fix "Hide Use this template button" ([#5249](#5249)) ([b399ecb](b399ecb))
* **YouTube:** Always use single threaded layout to resolve layout bugs in unpatched YouTube ([#5226](#5226)) ([1f539b1](1f539b1))
* **YouTube:** Fix refactoring app startup exception ([1b00c90](1b00c90))

### Features

* Add `Spoof app signature` patch ([#5158](#5158)) ([78b25aa](78b25aa))
* **Cricbuzz:** Add `Hide ads` patch ([#4998](#4998)) ([83ccfa8](83ccfa8))
* **Crunchyroll:** Add `Hide ads` patch ([#5201](#5201)) ([46b4398](46b4398))
* **YouTube - Hide Shorts components:** Add `Hide Effects button` ([#5255](#5255)) ([240897a](240897a))
* **YouTube - Hide video action buttons:** Add `Hide Stop ads` ([#5245](#5245)) ([274dcc6](274dcc6))
* **YouTube:** Add an option to disable toasts when changing default playback speed or quality ([#5230](#5230)) ([c68cde3](c68cde3))
* **YouTube:** Support version `20.13.41` ([#5253](#5253)) ([d284c3d](d284c3d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisoUseInAIKyrios LisoUseInAIKyrios LisoUseInAIKyrios left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(YouTube): Add an option to disable toasts when changing default playback speed or quality
2 participants
@MarcaDian @LisoUseInAIKyrios