Skip to content

feat(YouTube - Hide video action buttons): Add Hide Stop ads #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ILoveOpenSourceApplications
Copy link
Contributor

Closes #5244.

@LisoUseInAIKyrios
Copy link
Contributor

Maybe this should always hidden and there is no setting to enable/disable. I'm not sure why anyone would want to show this.

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Jun 24, 2025 that may be closed by this pull request
3 tasks
@ILoveOpenSourceApplications
Copy link
Contributor Author

Hide Save to playlist should simply be called Hide Save. Why the extra info?

@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented Jun 24, 2025

Maybe this should always hidden and there is no setting to enable/disable. I'm not sure why anyone would want to show this.

It's true, but out of the box if someone patches with Hide video action buttons patch, it's hidden, and I think that's enough.

Edit: Also, the button itself isn't showing anything intrusive as a button. Similar to how Hide Visit store button is sitting inside Hide ads rather than a Channel page components subpage.

@LisoUseInAIKyrios
Copy link
Contributor

Hide Save to playlist should simply be called Hide Save. Why the extra info?

"Hide Save" is ok. Not sure why it has been longer name.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube - Hide video action buttons): Add Hide Stop ads feat(YouTube - Hide video action buttons): Add "Hide Stop ads" Jun 24, 2025
@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented Jun 24, 2025

Is double quotations the way now for PR titles when adding something new? Previously it was to be ` symbol.

@LisoUseInAIKyrios
Copy link
Contributor

It's been used mostly for patches, not necessarily new in app settings. Seems to be slightly inconsistent in usage.

@ILoveOpenSourceApplications
Copy link
Contributor Author

I believe since this option is added for the first time, instead of quoting it, it should be inside a backwards quote.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube - Hide video action buttons): Add "Hide Stop ads" feat(YouTube - Hide video action buttons): Add Hide Stop ads Jun 24, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 274dcc6 into ReVanced:dev Jun 24, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
# [5.29.0-dev.6](v5.29.0-dev.5...v5.29.0-dev.6) (2025-06-24)

### Features

* **YouTube - Hide video action buttons:** Add `Hide Stop ads` ([#5245](#5245)) ([274dcc6](274dcc6))
@ILoveOpenSourceApplications ILoveOpenSourceApplications deleted the feat/hide-stop-ads-button branch June 24, 2025 12:22
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
# [5.29.0](v5.28.0...v5.29.0) (2025-06-26)

### Bug Fixes

* Add scrollable content to modern style settings dialogs ([#5211](#5211)) ([e6876d5](e6876d5))
* **Google Photos:** Resolve startup crash for Android 5.0 devices ([0294533](0294533))
* **YouTube - Hide ads:** Hide new type of product ad in video description ([#5225](#5225)) ([1e2efad](1e2efad))
* **YouTube - Hide layout components:** Fix "Hide video description attributes" ([#5250](#5250)) ([2f22d45](2f22d45))
* **YouTube - Hide Shorts components:** Fix "Hide Use this sound button" ([#5233](#5233)) ([5d6ec9e](5d6ec9e))
* **YouTube - Hide Shorts components:** Fix "Hide Use this template button" ([#5249](#5249)) ([b399ecb](b399ecb))
* **YouTube:** Always use single threaded layout to resolve layout bugs in unpatched YouTube ([#5226](#5226)) ([1f539b1](1f539b1))
* **YouTube:** Fix refactoring app startup exception ([1b00c90](1b00c90))

### Features

* Add `Spoof app signature` patch ([#5158](#5158)) ([78b25aa](78b25aa))
* **Cricbuzz:** Add `Hide ads` patch ([#4998](#4998)) ([83ccfa8](83ccfa8))
* **Crunchyroll:** Add `Hide ads` patch ([#5201](#5201)) ([46b4398](46b4398))
* **YouTube - Hide Shorts components:** Add `Hide Effects button` ([#5255](#5255)) ([240897a](240897a))
* **YouTube - Hide video action buttons:** Add `Hide Stop ads` ([#5245](#5245)) ([274dcc6](274dcc6))
* **YouTube:** Add an option to disable toasts when changing default playback speed or quality ([#5230](#5230)) ([c68cde3](c68cde3))
* **YouTube:** Support version `20.13.41` ([#5253](#5253)) ([d284c3d](d284c3d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(YouTube): Hide "Stop ads" player action button
2 participants