Upgrade reference to AWS SDK for .NET to the recently GA V4 version. #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 72.52% 72.52%
=======================================
Files 6 6
Lines 222 222
Branches 23 23
=======================================
Hits 161 161
Misses 52 52
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Amazon.SecretsManager.Extensions.Caching/Amazon.SecretsManager.Extensions.Caching.csproj
Outdated
Show resolved
Hide resolved
simonmarty
previously approved these changes
May 1, 2025
test/Amazon.SecretsManager.Extensions.Caching.IntegTests/IntegrationTests.cs
Outdated
Show resolved
Hide resolved
ThirdEyeSqueegee
previously approved these changes
May 1, 2025
simonmarty
approved these changes
May 1, 2025
ThirdEyeSqueegee
approved these changes
May 1, 2025
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The AWS SDK for .NET recently GA the V4 version. https://aws.amazon.com/blogs/developer/general-availability-of-aws-sdk-for-net-v4-0/
Updating this package to V4 unblocks users like this one aws/aws-sdk-net#3362 (comment) to move their application to V4.
The V4 is an evolutionary major version and we are expecting users to update fairly quickly and relatively short cycle of dual support with V3.
I made the version bump a major version bump since it forces users to update to V4 of the SDK.
Testing
I ran the tests in the solution and scanned the SDK usage for possible null collection issues. In V4 collection properties default to null. Only area I saw that could be a problem was in the
GetVersionmethod ofSecretCacheItemwhich already had a null check so was safe.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.