Skip to content

Upgrade reference to AWS SDK for .NET to the recently GA V4 version. #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2025
Merged

Upgrade reference to AWS SDK for .NET to the recently GA V4 version. #169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ddbbc1
Upgrade reference to AWS SDK for .NET to the recently GA V4 version.
normj May 1, 2025
bce52f9
Update Amazon.SecretsManager.Extensions.Caching.csproj
simonmarty May 1, 2025
d67a466
Update Amazon.SecretsManager.Extensions.Caching.csproj
simonmarty May 1, 2025
60d803d
Throw error instead of clarify intent
simonmarty May 1, 2025
4ae8437
Update IntegrationTests.cs
simonmarty May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Amazon.SecretsManager.Extensions.Caching/Amazon.SecretsManager.Extensions.Caching.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<OutputType>Library</OutputType>
<DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
<PackageId>AWSSDK.SecretsManager.Caching</PackageId>
<PackageVersion>2.0.0</PackageVersion>
<PackageVersion>3.0.0</PackageVersion>
<Title>AWS Secrets Manager Caching for .NET</Title>
<Authors>Amazon Web Services</Authors>
<Description>The AWS Secrets Manager .NET caching client enables in-process caching of secrets for .NET applications.</Description>
Expand All @@ -22,7 +22,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="AWSSDK.SecretsManager" Version="3.*" />
<PackageReference Include="AWSSDK.SecretsManager" Version="4.*" />
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.*" />
<PackageReference Include="StyleCop.Analyzers" Version="1.*">
<PrivateAssets>all</PrivateAssets>
Expand Down
4 changes: 2 additions & 2 deletions test/Amazon.SecretsManager.Extensions.Caching.IntegTests/IntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ private async Task FindPreviousTestSecrets()
foreach (SecretListEntry secret in secretList)
{
if (secret.Name.StartsWith(TestSecretPrefix)
&& DateTime.Compare(secret.LastChangedDate, twoDaysAgo) < 0
&& DateTime.Compare(secret.LastAccessedDate, twoDaysAgo) < 0)
&& DateTime.Compare(secret.LastChangedDate.GetValueOrDefault(), twoDaysAgo) < 0
&& DateTime.Compare(secret.LastAccessedDate.GetValueOrDefault(), twoDaysAgo) < 0)
{
SecretNamesToDelete.Add(secret.Name);
}
Expand Down
Loading