Skip to content

Return a Result from Image::resize #19376

Closed
@alice-i-cecile

Description

@alice-i-cecile

Nit: It's probably out of scope for this PR, but setting the size when we don't have any data feels weird. I'd put this in the condition 🤔 (and comment that it does nothing when called with a self.data equal to None.

The best would probably to return an Error, so user can react, but as self.data is exposed the test can just exist in user space.

Originally posted by @Vrixyz in #19116 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-RenderingDrawing game state to the screenC-UsabilityA targeted quality-of-life change that makes Bevy easier to useD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed upon

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions