Closed
Description
Nit: It's probably out of scope for this PR, but setting the size when we don't have any data feels weird. I'd put this in the condition 🤔 (and comment that it does nothing when called with a self.data
equal to None
.
The best would probably to return an Error
, so user can react, but as self.data
is exposed the test can just exist in user space.
Originally posted by @Vrixyz in #19116 (comment)