Remove warning from Image::resize #19116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecificProtagonist
added
A-Rendering
tychedelia
approved these changes
May 7, 2025
Vrixyz
reviewed
May 17, 2025
| @@ -850,16 +849,14 @@ impl Image { | |||
| } | |||
|
|
|||
| /// Resizes the image to the new size, by removing information or appending 0 to the `data`. | |||
| /// Does not properly resize the contents of the image, but only its internal `data` buffer. | |||
| /// Does not properly scale the contents of the image. | |||
| pub fn resize(&mut self, size: Extent3d) { | |||
| self.texture_descriptor.size = size; | |||
There was a problem hiding this comment.
Nit: It's probably out of scope for this PR, but setting the size when we don't have any data feels weird. I'd put this in the condition 🤔 (and comment that it does nothing when called with a self.data equal to None.
The best would probably to return an Error, so user can react, but as self.data is exposed the test can just exist in user space.
Vrixyz
approved these changes
May 17, 2025
Vrixyz
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Image::resizecurrently prints a warning when resizing an uninitializedImage, even though the resizing works correctly. For code that doesn't care about whether the image is initialized CP-side, this is inconvenient and unnecessary.