PlainYearMonth parsing and Calendar field resolution cleanup/fixes #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with handling
PlainYearMonth's calendar field resolution as well as aligningPlainYearMonth::new_with_overflowcloser to the specification behavior.This PR does introduce a new internal API
IsoDate::regulate, which does the regulation work without any date/time limit validations (year month has its ownyear_month_within_limitsvalidation).Tested on Boa locally, this does increase
Temporal.PlainYearMonth.fromconformance to near 100%. The remaining tests are related to other known issues: minus sign parsing and MonthCode validation.