Add with to PlainYearMonth #216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unfinished 9.3.13 with method
…ith_fallback_year_month macro
…in PlainYearMonth & PlainDate
PlainYearMonth.with() - issue#143(spec 9.3.13)
removed ArithmeticOverflow unit test
|
Closing this PR to rebase and clean up the commit history. I’ll open a new PR once the changes are properly structured |
Sounds good. I did make a few updates to potentially some relevant APIs this weekend during a cleanup. Hopefully it's not affecting your work too much. Feel free to reach out if you need help. Relevant PRs: #205 and #208. There's also a PR up on Boa currently for those |
jedel1043
added
C-enhancement
nekevss
pushed a commit
that referenced
this pull request
Mar 18, 2025
Restructured pull request of #216 Worked with @HenrikTennebekk on #143 Had to change temporal_capi/plain_year_month.rs hope this is fine? --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lockels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked with @HenrikTennebekk on #143
We encountered an issue in
temporal_capi/src/plain_year_month.rs.Error:
the trait Fromoptions::ffi::ArithmeticOverflow is not implemented for Option<temporal_rs::options::ArithmeticOverflow>
Unsure how to fix this.