Integrate MonthCode into public API and related adjustments
#208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Feb 23, 2025
jedel1043
approved these changes
Feb 23, 2025
nekevss
added a commit
that referenced
this pull request
Feb 23, 2025
This change integrate `MonthCode` into the public API of the partial fields and `month_code` methods in order to better represent [PrepareCalendarFields](https://tc39.es/proposal-temporal/#sec-temporal-preparecalendarfields) conversion. This does also add a host of public APIs to `MonthCode` for interacting with it and adjusts the general validation methods (although, I do suspect this will need to be iterated on in the future to better support more calendars). CC: @Manishearth as this includes updates to `temporal_capi`
nekevss
added a commit
that referenced
this pull request
Feb 24, 2025
This PR is a follow up to #208 and adds `MonthCode` validation on the ISO calendar path.
jedel1043
added
C-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change integrate
MonthCodeinto the public API of the partial fields andmonth_codemethods in order to better represent PrepareCalendarFields conversion.This does also add a host of public APIs to
MonthCodefor interacting with it and adjusts the general validation methods (although, I do suspect this will need to be iterated on in the future to better support more calendars).CC: @Manishearth as this includes updates to
temporal_capi