[ENH] Disallow empty string ids during add

[jairad26]

Description of changes

This PR disallows setting an empty string for an ID
#4346

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

---

This PR adds validation to prevent empty string IDs during the record addition process. It modifies the Rust codebase to reject IDs with zero characters by adding a new error type and appropriate validation check, addressing issue #4346.

Key Changes:
• Added a new EmptyId error type to the ToRecordsError enum
• Added validation to check for empty IDs in the to_records function
• Added comprehensive test cases to verify the validation behavior

Affected Areas:
• rust/frontend/src/impls/utils.rs

This summary was automatically generated by @propel-code-bot

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[jairad26]

• [ENH] Make metadata optional to allow deleting metadata in python client #4490
• [ENH] Disallow empty string ids during add #4488 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[propel-code-bot]

Disallow Empty String IDs During Record Addition

This PR adds validation to the Rust codebase to prevent empty string IDs (zero-length) when adding records to Chroma. It introduces a new error type EmptyId and adds a validation check in the to_records function to reject IDs without any characters.

Key Changes:
• Added EmptyId error type to ToRecordsError enum with appropriate error message
• Added validation check to reject empty string IDs in the to_records function
• Added comprehensive test cases to verify both error and success scenarios

Affected Areas:
• rust/frontend/src/impls/utils.rs

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

[TestCoverage]

You should add a test case for IDs containing valid non-empty values (including whitespace or unusual Unicode), to ensure is_empty() is the correct check and not overly restrictive. This will prevent regressions if the ID requirements change.

[propel-code-bot]

[BestPractice]

Since use super::*; is already present (line 100), the super:: prefix in super::to_records is redundant. You can call to_records directly.

[HammadB]

This seems inconsistent with the rest of our code where we use #[validate]