Skip to content

[BLD]: fix secret usage for Go test reusable workflow #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

codetheweb
Copy link
Contributor

Description of changes

#4479 added auth against DockerHub for higher rate limits when pulling, but I forgot to update the release workflow to properly propogate the secrets down.

Copy link

github-actions bot commented May 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

This PR adds the missing secrets: inherit line to the Go tests workflow in the release-chromadb.yml file. The change ensures proper authentication against DockerHub for higher rate limits when pulling images during the Go tests workflow.

This summary was automatically generated by @propel-code-bot

@codetheweb codetheweb merged commit 6928e04 into main May 9, 2025
40 checks passed
@codetheweb codetheweb deleted the bld-fix-go-test-workflow-secrets branch May 9, 2025 16:00
itaismith pushed a commit that referenced this pull request May 23, 2025
## Description of changes

#4479 added auth against
DockerHub for higher rate limits when pulling, but I forgot to update
the release workflow to properly propogate the secrets down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant