[DBG] Add temporary trace for filter argument #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
|
This PR adds temporary logging to help diagnose suspected issues with certain filters in the FTS algorithm. It also adds a more specific projection error variant for phantom records. This summary was automatically generated by @propel-code-bot |
sanketkedia
approved these changes
May 14, 2025
chroma-droid
pushed a commit
that referenced
this pull request
May 14, 2025
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Add temporary traces to log filter arguments. We suspect certain filters are not handled properly. - Add projection error variant for clarity - New functionality - N/A ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Sicheng-Pan
added a commit
that referenced
this pull request
May 14, 2025
This PR cherry-picks the commit 1880120 onto release/2025-05-09. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Macronova <[email protected]>
Sicheng-Pan
deleted the
sicheng/05-14-_dbg_add_temporary_trace_for_filter_argument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?