[CHORE] Remove validation on ef config update for model path

[jairad26]

Description of changes

Some embedding functions allow the user to pass a path for their embedding function. We should not be validating that the user is trying to update the model path, as that could be too restrictive.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[jairad26]

• [CHORE] Remove validation on ef config update for model path #4571 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

[propel-code-bot]

This PR removes the validation that previously prevented users from updating the 'model_name' (used as model path) in the configuration of instructor, sentence transformer, and text2vec embedding functions. Now, users can change the model path after initialization, enabling scenarios such as updating the path to a local or upgraded model file.

This summary was automatically generated by @propel-code-bot

[HammadB]

What is an example of a valid use here?

[HammadB]

Would be good to comment a tangible example

[jairad26]

came from a need of a user
https://discord.com/channels/1073293645303795742/1373083545936859257/1373083545936859257
this user (from my understanding) may have been testing some models from Sentence Transformers, and created a collection using a model directly from huggingface (sentence-transformers/msmarco-MiniLM-L6-cos-v5). They then downloaded the model locally since they moved behind a firewall, and now need to reference it via path. they would now be able to update the configuration with the new path with this change during collection.modify().

I can see a need where users move the paths of their models around, maybe for cleanup, maybe because they are updating apis from v1 to v2, and so need to update the file path for that. Will add a comment in the code too