[CHORE] Remove validation on ef config update for model path

chromadb/utils/embedding_functions/instructor_embedding_function.py

@@ -39,7 +39,7 @@ def __init__(
         self.device = device
         self.instruction = instruction
 
-        self._model = INSTRUCTOR(model_name, device=device)
+        self._model = INSTRUCTOR(model_name_or_path=model_name, device=device)
 
     def __call__(self, input: Documents) -> Embeddings:
         """
@@ -99,10 +99,10 @@ def get_config(self) -> Dict[str, Any]:
     def validate_config_update(
         self, old_config: Dict[str, Any], new_config: Dict[str, Any]
     ) -> None:
-        if "model_name" in new_config:
-            raise ValueError(
-                "The model name cannot be changed after the embedding function has been initialized."
-            )
+        # model_name is also used as the identifier for model path if stored locally.
+        # Users should be able to change the path if needed, so we should not validate that.
+        # e.g. moving file path from /v1/my-model.bin to /v2/my-model.bin
+        return
 
     @staticmethod
     def validate_config(config: Dict[str, Any]) -> None:

chromadb/utils/embedding_functions/sentence_transformer_embedding_function.py

@@ -42,7 +42,7 @@ def __init__(
 
         if model_name not in self.models:
             self.models[model_name] = SentenceTransformer(
-                model_name, device=device, **kwargs
+                model_name_or_path=model_name, device=device, **kwargs
             )
         self._model = self.models[model_name]
 
@@ -102,10 +102,10 @@ def get_config(self) -> Dict[str, Any]:
     def validate_config_update(
         self, old_config: Dict[str, Any], new_config: Dict[str, Any]
     ) -> None:
-        if "model_name" in new_config:
-            raise ValueError(
-                "The model name cannot be changed after the embedding function has been initialized."
-            )
+        # model_name is also used as the identifier for model path if stored locally.
+        # Users should be able to change the path if needed, so we should not validate that.
+        # e.g. moving file path from /v1/my-model.bin to /v2/my-model.bin
+        return
 
     @staticmethod
     def validate_config(config: Dict[str, Any]) -> None:

chromadb/utils/embedding_functions/text2vec_embedding_function.py

@@ -71,10 +71,10 @@ def get_config(self) -> Dict[str, Any]:
     def validate_config_update(
         self, old_config: Dict[str, Any], new_config: Dict[str, Any]
     ) -> None:
-        if "model_name" in new_config:
-            raise ValueError(
-                "The model name cannot be changed after the embedding function has been initialized."
-            )
+        # model_name is also used as the identifier for model path if stored locally.
+        # Users should be able to change the path if needed, so we should not validate that.
+        # e.g. moving file path from /v1/my-model.bin to /v2/my-model.bin
+        return
 
     @staticmethod
     def validate_config(config: Dict[str, Any]) -> None: