[BUG]: don't create duplicate segments for collection under concurrent get_or_create requests

[codetheweb]

Description of changes

Prior to this change, the was_created flag was not correctly propagated up to the caller of createCollectionImpl(). This resulted in two concurrent create collection requests with get_or_create: true creating duplicate segments.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Did not add a new test.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

[propel-code-bot]

Fix: Prevent Duplicate Segments on Concurrent get_or_create Collection Requests

This PR addresses a concurrency issue in collection creation where the 'was_created' flag was not correctly propagated, resulting in duplicate segment creation under simultaneous get_or_create requests. The change ensures that the 'created' status is properly returned, preventing segment creation unless the collection was actually created during the request.

Key Changes:
• Correctly propagate 'created' status up to caller in createCollectionImpl()
• Ensure segments are not created for existing collections during concurrent get_or_create operations
• Removed an outdated TODO comment about segment existence checks

Affected Areas:
• go/pkg/sysdb/coordinator/table_catalog.go (collection creation and segment creation logic)

This summary was automatically generated by @propel-code-bot

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)