Skip to content

[HOTFIX] applying PR #4647 to release/2025-05-16 #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[HOTFIX] applying PR #4647 to release/2025-05-16 #4650

merged 1 commit into from
May 28, 2025

Conversation

chroma-droid
Copy link

This PR cherry-picks the commit 316cd5f onto release/2025-05-16. If there are unresolved conflicts, please resolve them manually.

@codetheweb @github-actions
[BUG]: don't create duplicate segments for collection under concurren…
cd02c3e 
…t get_or_create requests (#4647)

## Description of changes

Prior to this change, the `was_created` flag was not correctly
propagated up to the caller of `createCollectionImpl()`. This resulted
in two concurrent create collection requests with `get_or_create: true`
creating duplicate segments.

## Test plan

_How are these changes tested?_

- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

Did not add a new test.

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_

n/a
@chroma-droid chroma-droid requested a review from codetheweb May 28, 2025 18:11
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb merged commit 17d696e into release/2025-05-16 May 28, 2025
67 of 69 checks passed
@codetheweb codetheweb deleted the hotfix-4647/release/2025-05-16 branch May 28, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codetheweb codetheweb Awaiting requested review from codetheweb

Assignees

@codetheweb codetheweb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chroma-droid @codetheweb