Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

Add documentation link in discovery files #121

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

kaldebert
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@codecov-io
Copy link

codecov-io commented Jan 2, 2018

Codecov Report

Merging #121 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #121      +/-   ##
============================================
+ Coverage     79.75%   79.79%   +0.04%     
- Complexity     1652     1654       +2     
============================================
  Files           156      156              
  Lines          5536     5538       +2     
  Branches        710      711       +1     
============================================
+ Hits           4415     4419       +4     
+ Misses          843      842       -1     
+ Partials        278      277       -1
Impacted Files Coverage Δ Complexity Δ
...e/api/server/spi/discovery/DiscoveryGenerator.java 87.68% <100%> (+0.12%) 52 <0> (+1) ⬆️
...i/config/annotationreader/ApiAnnotationConfig.java 88.37% <0%> (+2.32%) 49% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ea315...18dc950. Read the comment docs.

@googlebot
Copy link

CLAs look good, thanks!

@kaldebert
Copy link
Author

I signed it!

@clementdenis
Copy link
Contributor

Hi @tangiel, is there anything else we should do to have this one merged?
It's actually a regression from Cloud Endpoints v1, documentationLink used to be displayed.
Thanks!

@tangiel tangiel merged commit 49d17fc into cloudendpoints:master Feb 2, 2018
@tangiel
Copy link
Contributor

tangiel commented Feb 2, 2018

Nope, sorry for missing it. Thanks!

@clementdenis clementdenis deleted the add_documentation_link branch July 31, 2018 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants