Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

Discovery document improvements #93

Closed
wants to merge 2 commits into from

Conversation

urmuzov
Copy link

@urmuzov urmuzov commented May 19, 2017

added documentationLink property
@description for enum constants and fields

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@codecov-io
Copy link

codecov-io commented May 19, 2017

Codecov Report

Merging #93 into master will decrease coverage by 0.15%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
- Coverage     79.47%   79.31%   -0.16%     
  Complexity     1621     1621              
============================================
  Files           154      154              
  Lines          5461     5478      +17     
  Branches        703      708       +5     
============================================
+ Hits           4340     4345       +5     
- Misses          847      854       +7     
- Partials        274      279       +5
Impacted Files Coverage Δ Complexity Δ
...com/google/api/server/spi/config/model/Schema.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...e/api/server/spi/discovery/DiscoveryGenerator.java 84.76% <30%> (-2.87%) 51 <0> (ø)
.../api/server/spi/config/model/SchemaRepository.java 87.85% <54.54%> (-3.99%) 26 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe63f3...239e96d. Read the comment docs.

@urmuzov
Copy link
Author

urmuzov commented May 19, 2017

@tangiel @bradfriedman Guys, please have a look. Changes are pretty shallow.

Can you help me to figure out where to add tests to cover changes?

@googlebot
Copy link

CLAs look good, thanks!

@tangiel
Copy link
Contributor

tangiel commented Aug 8, 2017

Sorry for the super slow replies; if you're still up for it, you want to follow the test pattern found in SwaggerGeneratorTest and DiscoveryGeneratorTest. Basically write a test endpoint using the new annotations and confirm its output.

@clementdenis
Copy link
Contributor

We've split the improvements brought by this PR and added some tests:

Maybe this one should be closed.

@tangiel tangiel closed this Feb 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants