Skip to content

Bump up version to 1.3.1-rc1 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Bump up version to 1.3.1-rc1 #324

merged 2 commits into from
May 26, 2025

Conversation

milindl
Copy link
Contributor

@milindl milindl commented May 23, 2025

@Copilot Copilot AI review requested due to automatic review settings May 23, 2025 05:15
@milindl milindl requested review from a team as code owners May 23, 2025 05:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version from 1.3.0 to 1.3.1-rc1 across the package configuration, binding module, and documentation.

  • Updated package.json version field
  • Updated lib/util.js bindingVersion
  • Added a new version mapping entry in README.md

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updated the version field to "1.3.1-rc1"
lib/util.js Updated the bindingVersion value to "1.3.1-rc1"
README.md Added a new mapping entry for version "1.3.1" (potential inconsistency with the "-rc1" suffix)

@@ -113,6 +113,7 @@ For guidelines on contributing please see [CONTRIBUTING.md](CONTRIBUTING.md)
| 1.0.0 | 2.6.1 |
| 1.2.0 | 2.8.0 |
| 1.3.0 | 2.10.0 |
| 1.3.1 | 2.10.0 |
Copy link
Preview

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version mapping in the README does not include the '-rc1' suffix, which is inconsistent with package.json and lib/util.js. Consider updating the entry to '1.3.1-rc1' for consistency.

Copilot uses AI. Check for mistakes.

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (71.80% Estimated after merge)
  • Duplications No duplication information (2.00% Estimated after merge)

Project ID: confluent-kafka-javascript

View in SonarQube

@milindl milindl merged commit 4258a2e into master May 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants