Skip to content

Bump up version to 1.3.1-rc1 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Bump up version to 1.3.1-rc1 #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5529a64
Bump version
milindl May 23, 2025
0bcc879
Remove dev from version
milindl May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ For guidelines on contributing please see [CONTRIBUTING.md](CONTRIBUTING.md)
| 1.0.0 | 2.6.1 |
| 1.2.0 | 2.8.0 |
| 1.3.0 | 2.10.0 |
| 1.3.1 | 2.10.0 |
Copy link
Preview

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version mapping in the README does not include the '-rc1' suffix, which is inconsistent with package.json and lib/util.js. Consider updating the entry to '1.3.1-rc1' for consistency.

Copilot uses AI. Check for mistakes.


This mapping is applicable if you're using a pre-built binary. Otherwise, you can check the librdkafka version with the following command:

Expand Down
2 changes: 1 addition & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ util.dictToStringList = function (mapOrObject) {
return list;
};

util.bindingVersion = '1.3.0';
util.bindingVersion = '1.3.1-rc1';
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@confluentinc/kafka-javascript",
"version": "1.3.0",
"version": "1.3.1-rc1",
"description": "Node.js bindings for librdkafka",
"librdkafka": "2.10.0",
"librdkafka_win": "2.10.0",
Expand Down