Update from main protocol squad (#1094)

* update left/right click button behaviour on renderer (#1078)

* update left/right click button behaviour on renderer

* remove gizmo right click button

* fixed review comments

* remove desktop client (OLD) option (#1083)

* select "Scene" in tree on startup (#1082)

* update left/right click button behaviour on renderer

* select 'Scene' in tree on startup

* add refresh button for Assets (#1085)

* support border in uitransforms (#1084)

* support border in uitransforms

* fix build

* change protocol to experimental

* use main protocol

* fix snapshots test

* fix tests

* fix coverage

* update protocol

* export useEffect & useState (#1089)

* export useEffect & useState

* fix tests

* fix: Animation weight value (#1090)

* fix: Animation weight value

* fix: Animation weight and speed default value

* revert .vscode/settings.json

* lint

* update .crdt

* fix models removal when using filters (#1088)

* add video player to syncEntities (#1097)

* add skip-auth-screen & landscape-terrain-enabled options for preview (#1096)

* chore: Add check local packages action (#1092)

* chore: Update asset-packs package

* fix: Allow dev package

* chore: Move check no local packages to a GHAction

* chore: Update asset-packs package

* fix: Convert TS file to CJS

* fix: GHAction comment id

* chore: Move local dependencies check to ci pipeline

* fix: debug downloaded files

* chore: Enhance message

* chore: simplify comment dependencies logic

* chore: Generate comment.md to properly show in the PR

* fix: string comment

* fix: error detection

* fix: check exit code

* fix: catch exit code

* chore: Update @dcl/asset-packs

* remove AudioSource component from not sync list (#1099)

* add entity highlight when selected (#1103)

* fix: Handle components schemas errors (#1098)

* fix: Basic view TweenComponent to better handle empty entities

* fix: Sync external changes

* feat: Add Default Basic View Field

* fix: Add SyncComponents to Smart Items when using the AdminTools (#1100)

* chore: Update @dcl/asset-packs package

* fix: Update createEnumEntityId

* feat: Add new util addSyncComponentsToEntities to add the Synccomponent and Network component to multiple entities

* fix: Tests

* chore: Update @dcl/asset-packs package

* fix: Remove components for actions that doesn't create components on the fly

* fix: Add a validation to avoid include Tween and Transform in the SyncComponent at the same time

* chore: Update @dcl/asset-packs

* update @dcl/[email protected] (#1106)

* feat: add type safe entity names file (#1107)

* feat: add type safe entity names file

* fix build:

* simplify enum types

* update tests

* fix bad merge issue with onChange

* feat: change shortcut for rotating camera (#1110)

Co-authored-by: Alejandra Levy <[email protected]>

* fix Texture being flipped vertically (#1111)

* add video screen (#1105)

* add video screen

* update asset-packs package

* update ui

* update asset-packs

* update asset-packs

* fix ui styles

* fix volume and losing focus

* update assert-packs

* bump asset-packs

* feat: add search param to actions dropdown (#1113)

* feat: add search param to actions dropdown
* feat: add searchable in Trigger Action and Trigger Basic View

* feat: show selected entity first on dropdown (#1112)

* feat: show selected entity first on dropdown

* feat: remove unused import and reorder import

* Update packages/@dcl/inspector/src/components/ui/EntityField/EntityField.tsx

Co-authored-by: Gabriel Díaz <[email protected]>
Signed-off-by: Alejandra Levy <[email protected]>

* feat: update method

---------

Signed-off-by: Alejandra Levy <[email protected]>
Co-authored-by: Gabriel Díaz <[email protected]>

* Support jpg textures (#1114)

* feat: support jpg & jpge textures

* feat: support jpg and jpeg for all images inputs

* feat: update validation for textures

* feat: Update regez to support .jpg and .jpge extensions

* feat: fix lint issues

* feat: add validation on input change

* feat: change regex to pass tests

* feat: update validation on component

* feat: add error message for invalid URL and stop validating empty field

* feat: update message

* Update global value on Audio Source component (#1119)

* feat: update global value & validate source input only where there's a value

* feat: remove debugger

* Support global prop on play sound action (#1120)

* feat: support global prop on play sound action

* feat: update pacjkage json

* feat: update package json and fix issues

* feat: install asset packs version

* feat: update asset pack version

* feat: install asset packs version on inspector

* feat: remove asset packs from root package.json

* feat: update package-lock

* fix enter scene callback not being fired if there is no onLeaveCb (#1124)

* fix enter scene callback not being fired if there is no onLeaveCb

* fix tests and update asset-packs

* feat: cursor position info (#1123)

* Updated protocol and added test for the new PrimaryPointerInfo component

* Lint-fix pass

* fix play video not updaing src property (#1129)

* add default emotes (#1132)

* feat: 4088 add z-index support for ui elements (#1127)

* Updated protocol pointers to dev branch

* Added zIndex to the react-ecs component and test

(cherry picked from commit 7ea5cfd)

* Added opacity property to ui elements

* Fixed tests

* Updated protocol

* Updated snapshots

* Removed redundant definitions. Added test coverage

* Adjusted the default value in test

* ui transform  test wip

* Added more tests. Refactored parseUiTransform utility function to properly handle the new properties

* Deep clean and snapshot

* Removed redundant tests, removed redundant defaults definitions.

* Updated snapshots

* Updated default value for opacity and updated snapshots

* feat: Update asset packs package (#1135)

* update protocol from protocol-squad branch
add "make update-protocol-squad"

* fixes and update crdt snapshots

* reduce coverage to 90% for protocol-squad branch

* update protocol (add setUiFocus)

---------

Signed-off-by: Alejandra Levy <[email protected]>
Co-authored-by: Nicolas Echezarreta <[email protected]>
Co-authored-by: Gon Pombo <[email protected]>
Co-authored-by: Gabriel Díaz <[email protected]>
Co-authored-by: Alejandra Levy <[email protected]>
Co-authored-by: Alejandra Levy <[email protected]>
Co-authored-by: Alejandro Alvarez Melucci <[email protected]>

Author: 7 people

.github/scripts/check-no-local-packages.cjs

@@ -0,0 +1,85 @@
+const fs = require('fs')
+const path = require('path')
+
+// Function to recursively find all package.json files
+function findPackageJsonFiles(dir, fileList = []) {
+  const files = fs.readdirSync(dir)
+
+  for (const file of files) {
+    const filePath = path.join(dir, file)
+    const stat = fs.statSync(filePath)
+
+    if (stat.isDirectory() && !filePath.includes('node_modules')) {
+      findPackageJsonFiles(filePath, fileList)
+    } else if (file === 'package.json') {
+      fileList.push(filePath)
+    }
+  }
+
+  return fileList
+}
+
+// Check for local package dependencies
+function checkNoLocalPackages(packageJsonPath) {
+  try {
+    const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8'))
+    const errors = []
+
+    // Check both dependencies and devDependencies
+    for (const deps of [packageJson.dependencies, packageJson.devDependencies]) {
+      if (!deps) continue
+
+      for (const [key, value] of Object.entries(deps)) {
+        if (
+          value.startsWith('file:') ||
+          value.startsWith('http:') ||
+          value.startsWith('https:') ||
+          value.startsWith('git:')
+        ) {
+          errors.push(`Dependency ${key} is not pointing to a published version: ${value}`)
+        }
+      }
+    }
+
+    if (errors.length) {
+      console.error(`\n\nErrors in ${packageJsonPath}:`)
+      errors.forEach((error) => console.error(`- ${error}`))
+      return false
+    }
+
+    return true
+  } catch (error) {
+    console.error(`Error processing ${packageJsonPath}: ${error.message}`)
+    return false
+  }
+}
+
+// Main function
+function main() {
+  // Check if a directory was passed as an argument
+  const targetDir = process.argv[2] || '.'
+
+  console.log(`Checking for local package dependencies in ${targetDir}...`)
+  const packageJsonFiles = findPackageJsonFiles(targetDir)
+  console.log(`Found ${packageJsonFiles.length} package.json files to check.`)
+
+  let hasErrors = false
+
+  for (const packageJsonPath of packageJsonFiles) {
+    console.log(`Checking ${packageJsonPath}...`)
+    if (!checkNoLocalPackages(packageJsonPath)) {
+      hasErrors = true
+    }
+  }
+
+  if (hasErrors) {
+    console.error(
+      `\n\nFound packages with local dependencies in ${targetDir}. Please publish these dependencies instead of using local references.`
+    )
+    process.exit(1)
+  } else {
+    console.log(`\n\nNo local dependencies found in ${targetDir}. All good!`)
+  }
+}
+
+main()

.vscode/settings.json

@@ -19,6 +19,6 @@
     "packages/@dcl/inspector/hot-reload.js": false
   },
   "[typescript]": {
-    "editor.defaultFormatter": "vscode.typescript-language-features"
+    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
   }
 }

Makefile

@@ -36,6 +36,11 @@ update-protocol:
 	cd packages/@dcl/sdk-commands; npm i --save-exact @dcl/protocol@next
 	$(MAKE) sync-deps compile_apis
 
+update-protocol-squad:
+	npm i --save-exact @dcl/protocol@protocol-squad
+	cd packages/@dcl/sdk-commands; npm i --save-exact @dcl/protocol@protocol-squad
+	$(MAKE) sync-deps compile_apis
+
 update-renderer:
 	cd packages/@dcl/sdk; npm i --save-exact @dcl/explorer@latest
 

jest.config.js

@@ -15,10 +15,10 @@ module.exports = {
   coverageDirectory: "coverage",
   coverageThreshold: {
     global: {
-      branches: 100,
-      functions: 100,
-      lines: 100,
-      statements: 100,
+      branches: 90,
+      functions: 90,
+      lines: 90,
+      statements: 90,
     },
     "packages/@dcl/ecs/src/systems/crdt/index.ts": {
       // This should be deleted on another PR. Need to release this asap.

package-lock.json

@@ -6,7 +6,7 @@
   "bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
   "dependencies": {
     "@actions/core": "^1.10.0",
-    "@dcl/protocol": "1.0.0-14231413869.commit-0c50705",
+    "@dcl/protocol": "1.0.0-15736212864.commit-41e200e",
     "@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1",
     "@dcl/ts-proto": "1.153.0",
     "@types/fs-extra": "^9.0.12",

package.json

@@ -2,12 +2,11 @@ import { IEngine, LastWriteWinElementSetComponentDefinition } from '../../engine
 import { AvatarEquippedDataSchema } from '../generated/AvatarEquippedData.gen'
 import { PBAvatarEquippedData } from '../generated/pb/decentraland/sdk/components/avatar_equipped_data.gen'
 
-
 /**
  * @public
  */
-export interface AvatarEquippedDataComponentDefinitionExtended
-  extends LastWriteWinElementSetComponentDefinition<AvatarEquippedDataType> { }
+export type AvatarEquippedDataComponentDefinitionExtended =
+  LastWriteWinElementSetComponentDefinition<AvatarEquippedDataType>
 
 export type AvatarEquippedDataType = Omit<PBAvatarEquippedData, 'forceRender'> & {
   forceRender?: string[] | undefined
@@ -26,6 +25,6 @@ export function defineAvatarEquippedDataComponent(
     }
   }
 
-  const theComponent = engine.defineComponentFromSchema("core::AvatarEquippedData", patchedSchema);
+  const theComponent = engine.defineComponentFromSchema('core::AvatarEquippedData', patchedSchema)
   return theComponent as unknown as AvatarEquippedDataComponentDefinitionExtended
 }

packages/@dcl/ecs/src/components/extended/AvatarEquippedData.ts

@@ -2,12 +2,10 @@ import { IEngine, LastWriteWinElementSetComponentDefinition } from '../../engine
 import { AvatarShapeSchema } from '../generated/AvatarShape.gen'
 import { PBAvatarShape } from '../generated/pb/decentraland/sdk/components/avatar_shape.gen'
 
-
 /**
  * @public
  */
-export interface AvatarShapeComponentDefinitionExtended
-  extends LastWriteWinElementSetComponentDefinition<AvatarShapeType> { }
+export type AvatarShapeComponentDefinitionExtended = LastWriteWinElementSetComponentDefinition<AvatarShapeType>
 
 export type AvatarShapeType = Omit<PBAvatarShape, 'forceRender'> & {
   forceRender?: string[] | undefined
@@ -26,6 +24,6 @@ export function defineAvatarShapeComponent(
     }
   }
 
-  const theComponent = engine.defineComponentFromSchema("core::AvatarShape", patchedSchema);
+  const theComponent = engine.defineComponentFromSchema('core::AvatarShape', patchedSchema)
   return theComponent as unknown as AvatarShapeComponentDefinitionExtended
 }

packages/@dcl/ecs/src/components/extended/AvatarShape.ts

@@ -3,7 +3,10 @@ import { IEngine } from '../engine/types'
 import { AnimatorComponentDefinitionExtended, defineAnimatorComponent } from './extended/Animator'
 import { AudioSourceComponentDefinitionExtended, defineAudioSourceComponent } from './extended/AudioSource'
 import { AudioStreamComponentDefinitionExtended, defineAudioStreamComponent } from './extended/AudioStream'
-import { AvatarEquippedDataComponentDefinitionExtended, defineAvatarEquippedDataComponent } from './extended/AvatarEquippedData'
+import {
+  AvatarEquippedDataComponentDefinitionExtended,
+  defineAvatarEquippedDataComponent
+} from './extended/AvatarEquippedData'
 import { AvatarShapeComponentDefinitionExtended, defineAvatarShapeComponent } from './extended/AvatarShape'
 import { defineInputModifierComponent, InputModifierComponentDefinitionExtended } from './extended/InputModifier'
 import { defineMaterialComponent, MaterialComponentDefinitionExtended } from './extended/Material'
@@ -22,7 +25,9 @@ import { defineTransformComponent, TransformComponentExtended } from './manual/T
 export * from './generated/index.gen'
 
 export type {
-  GrowOnlyValueSetComponentDefinition, GSetComponentGetter, LastWriteWinElementSetComponentDefinition,
+  GrowOnlyValueSetComponentDefinition,
+  GSetComponentGetter,
+  LastWriteWinElementSetComponentDefinition,
   LwwComponentGetter
 }
 
@@ -58,10 +63,12 @@ export const MeshCollider: LwwComponentGetter<MeshColliderComponentDefinitionExt
 export const Tween: LwwComponentGetter<TweenComponentDefinitionExtended> = (engine) => defineTweenComponent(engine)
 
 /* @__PURE__ */
-export const AvatarShape: LwwComponentGetter<AvatarShapeComponentDefinitionExtended> = (engine) => defineAvatarShapeComponent(engine)
+export const AvatarShape: LwwComponentGetter<AvatarShapeComponentDefinitionExtended> = (engine) =>
+  defineAvatarShapeComponent(engine)
 
 /* @__PURE__ */
-export const AvatarEquippedData: LwwComponentGetter<AvatarEquippedDataComponentDefinitionExtended> = (engine) => defineAvatarEquippedDataComponent(engine)
+export const AvatarEquippedData: LwwComponentGetter<AvatarEquippedDataComponentDefinitionExtended> = (engine) =>
+  defineAvatarEquippedDataComponent(engine)
 
 /* @__PURE__ */
 export const VirtualCamera: LwwComponentGetter<VirtualCameraComponentDefinitionExtended> = (engine) =>

packages/@dcl/ecs/src/components/index.ts

@@ -3,7 +3,10 @@ export type { AudioSourceComponentDefinitionExtended } from './extended/AudioSou
 export type { AudioStreamComponentDefinitionExtended } from './extended/AudioStream'
 export type { MeshRendererComponentDefinitionExtended } from './extended/MeshRenderer'
 export type { MeshColliderComponentDefinitionExtended } from './extended/MeshCollider'
-export type { AvatarEquippedDataComponentDefinitionExtended, AvatarEquippedDataType } from './extended/AvatarEquippedData'
+export type {
+  AvatarEquippedDataComponentDefinitionExtended,
+  AvatarEquippedDataType
+} from './extended/AvatarEquippedData'
 export type { AvatarShapeComponentDefinitionExtended, AvatarShapeType } from './extended/AvatarShape'
 export type { TextureHelper, MaterialComponentDefinitionExtended } from './extended/Material'
 export type { TweenHelper, TweenComponentDefinitionExtended } from './extended/Tween'

packages/@dcl/ecs/src/components/types.ts

@@ -189,14 +189,19 @@ function preEngine(options?: IEngineOptions): PreEngine {
     }
   }
 
-  function getEntityOrNullByName(value: string) {
+  function getEntityOrNullByName<T = string>(value: T) {
     const NameComponent = components.Name({ defineComponent })
     for (const [entity, name] of getEntitiesWith(NameComponent)) {
       if (name.value === value) return entity
     }
     return null
   }
 
+  function getEntityByName<T = never, K = T>(value: K & (T extends never ? never : string)): Entity {
+    const entity = getEntityOrNullByName(value)
+    return entity!
+  }
+
   function* getComponentDefGroup<T extends ComponentDefinition<any>[]>(...args: T): Iterable<[Entity, ...T]> {
     const [firstComponentDef, ...componentDefinitions] = args
     for (const [entity] of firstComponentDef.iterator()) {
@@ -252,6 +257,7 @@ function preEngine(options?: IEngineOptions): PreEngine {
     getComponent,
     getComponentOrNull: getComponentOrNull as IEngine['getComponentOrNull'],
     getEntityOrNullByName,
+    getEntityByName,
     removeComponentDefinition,
     registerComponentDefinition,
     entityContainer,
@@ -313,6 +319,7 @@ export function Engine(options?: IEngineOptions): IEngine {
     componentsIter: partialEngine.componentsIter,
     seal: partialEngine.seal,
     getEntityOrNullByName: partialEngine.getEntityOrNullByName,
+    getEntityByName: partialEngine.getEntityByName,
 
     update,