fix enter scene callback not being fired if there is no onLeaveCb #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying js-sdk-toolchain with
|
| Latest commit: |
9cc1d63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2321134c.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://fix-enter-scene-callback.js-sdk-toolchain.pages.dev |
Test this pull request
|
kuruk-mm
added a commit
that referenced
this pull request
Jun 19, 2025
* update left/right click button behaviour on renderer (#1078) * update left/right click button behaviour on renderer * remove gizmo right click button * fixed review comments * remove desktop client (OLD) option (#1083) * select "Scene" in tree on startup (#1082) * update left/right click button behaviour on renderer * select 'Scene' in tree on startup * add refresh button for Assets (#1085) * support border in uitransforms (#1084) * support border in uitransforms * fix build * change protocol to experimental * use main protocol * fix snapshots test * fix tests * fix coverage * update protocol * export useEffect & useState (#1089) * export useEffect & useState * fix tests * fix: Animation weight value (#1090) * fix: Animation weight value * fix: Animation weight and speed default value * revert .vscode/settings.json * lint * update .crdt * fix models removal when using filters (#1088) * add video player to syncEntities (#1097) * add skip-auth-screen & landscape-terrain-enabled options for preview (#1096) * chore: Add check local packages action (#1092) * chore: Update asset-packs package * fix: Allow dev package * chore: Move check no local packages to a GHAction * chore: Update asset-packs package * fix: Convert TS file to CJS * fix: GHAction comment id * chore: Move local dependencies check to ci pipeline * fix: debug downloaded files * chore: Enhance message * chore: simplify comment dependencies logic * chore: Generate comment.md to properly show in the PR * fix: string comment * fix: error detection * fix: check exit code * fix: catch exit code * chore: Update @dcl/asset-packs * remove AudioSource component from not sync list (#1099) * add entity highlight when selected (#1103) * fix: Handle components schemas errors (#1098) * fix: Basic view TweenComponent to better handle empty entities * fix: Sync external changes * feat: Add Default Basic View Field * fix: Add SyncComponents to Smart Items when using the AdminTools (#1100) * chore: Update @dcl/asset-packs package * fix: Update createEnumEntityId * feat: Add new util addSyncComponentsToEntities to add the Synccomponent and Network component to multiple entities * fix: Tests * chore: Update @dcl/asset-packs package * fix: Remove components for actions that doesn't create components on the fly * fix: Add a validation to avoid include Tween and Transform in the SyncComponent at the same time * chore: Update @dcl/asset-packs * update @dcl/[email protected] (#1106) * feat: add type safe entity names file (#1107) * feat: add type safe entity names file * fix build: * simplify enum types * update tests * fix bad merge issue with onChange * feat: change shortcut for rotating camera (#1110) Co-authored-by: Alejandra Levy <[email protected]> * fix Texture being flipped vertically (#1111) * add video screen (#1105) * add video screen * update asset-packs package * update ui * update asset-packs * update asset-packs * fix ui styles * fix volume and losing focus * update assert-packs * bump asset-packs * feat: add search param to actions dropdown (#1113) * feat: add search param to actions dropdown * feat: add searchable in Trigger Action and Trigger Basic View * feat: show selected entity first on dropdown (#1112) * feat: show selected entity first on dropdown * feat: remove unused import and reorder import * Update packages/@dcl/inspector/src/components/ui/EntityField/EntityField.tsx Co-authored-by: Gabriel Díaz <[email protected]> Signed-off-by: Alejandra Levy <[email protected]> * feat: update method --------- Signed-off-by: Alejandra Levy <[email protected]> Co-authored-by: Gabriel Díaz <[email protected]> * Support jpg textures (#1114) * feat: support jpg & jpge textures * feat: support jpg and jpeg for all images inputs * feat: update validation for textures * feat: Update regez to support .jpg and .jpge extensions * feat: fix lint issues * feat: add validation on input change * feat: change regex to pass tests * feat: update validation on component * feat: add error message for invalid URL and stop validating empty field * feat: update message * Update global value on Audio Source component (#1119) * feat: update global value & validate source input only where there's a value * feat: remove debugger * Support global prop on play sound action (#1120) * feat: support global prop on play sound action * feat: update pacjkage json * feat: update package json and fix issues * feat: install asset packs version * feat: update asset pack version * feat: install asset packs version on inspector * feat: remove asset packs from root package.json * feat: update package-lock * fix enter scene callback not being fired if there is no onLeaveCb (#1124) * fix enter scene callback not being fired if there is no onLeaveCb * fix tests and update asset-packs * feat: cursor position info (#1123) * Updated protocol and added test for the new PrimaryPointerInfo component * Lint-fix pass * fix play video not updaing src property (#1129) * add default emotes (#1132) * feat: 4088 add z-index support for ui elements (#1127) * Updated protocol pointers to dev branch * Added zIndex to the react-ecs component and test (cherry picked from commit 7ea5cfd) * Added opacity property to ui elements * Fixed tests * Updated protocol * Updated snapshots * Removed redundant definitions. Added test coverage * Adjusted the default value in test * ui transform test wip * Added more tests. Refactored parseUiTransform utility function to properly handle the new properties * Deep clean and snapshot * Removed redundant tests, removed redundant defaults definitions. * Updated snapshots * Updated default value for opacity and updated snapshots * feat: Update asset packs package (#1135) * update protocol from protocol-squad branch add "make update-protocol-squad" * fixes and update crdt snapshots * reduce coverage to 90% for protocol-squad branch * update protocol (add setUiFocus) --------- Signed-off-by: Alejandra Levy <[email protected]> Co-authored-by: Nicolas Echezarreta <[email protected]> Co-authored-by: Gon Pombo <[email protected]> Co-authored-by: Gabriel Díaz <[email protected]> Co-authored-by: Alejandra Levy <[email protected]> Co-authored-by: Alejandra Levy <[email protected]> Co-authored-by: Alejandro Alvarez Melucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.