Skip to content

remove desktop client (OLD) option #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

remove desktop client (OLD) option #1083

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e31ae7
remove desktop client (OLD) option
gonpombo8 Mar 19, 2025
667db10
Merge branch 'main' into remove/desktop-client-option
gonpombo8 Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions packages/@dcl/sdk-commands/src/commands/start/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export const args = declareArgs({
'-b': '--no-browser',
'-w': '--no-watch',
'--skip-build': Boolean,
'--desktop-client': Boolean,
'--data-layer': Boolean,
'--explorer-alpha': Boolean,
'--hub': Boolean,
Expand All @@ -75,7 +74,6 @@ export async function help(options: Options) {
-c, --ci Run the parcel previewer on a remote unix server
--web3 Connects preview to browser wallet to use the associated avatar and account
--skip-build Skip build and only serve the files in preview mode
--desktop-client Show URL to launch preview in the desktop client (BETA)
--debug Enables Debug panel mode inside DCL Explorer (default=true)
--dclenv Decentraland Environment. Which environment to use for the content. This determines the catalyst server used, asset-bundles, etc. Possible values: org, zone, today. (default=org)
--realm Realm used to serve the content. (default=Localhost)
Expand Down Expand Up @@ -227,15 +225,6 @@ export async function main(options: Options) {
}
}

if (options.args['--desktop-client']) {
components.logger.log('\n Desktop client:\n')
for (const addr of sortedURLs) {
const searchParams = new URLSearchParams()
searchParams.append('PREVIEW-MODE', addr)
components.logger.log(` dcl://${searchParams.toString()}&`)
}
}

if (!explorerAlpha) {
components.logger.log('\n Details:\n')
}
Expand All @@ -247,7 +236,7 @@ export async function main(options: Options) {
}

// Open preferably localhost/127.0.0.1
if (!explorerAlpha && openBrowser && sortedURLs.length && !options.args['--desktop-client']) {
if (!explorerAlpha && openBrowser && sortedURLs.length) {
try {
await open(sortedURLs[0])
} catch (_) {
Expand Down
Loading